Implement CouchDB.info() #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmario
requested changes
Mar 19, 2020
aiocouch/couchdb.py
Outdated
| @@ -39,3 +39,6 @@ def __init__(self, *args, **kwargs): | |||
|
|
|||
| async def keys(self, **params): | |||
| return await self._server._all_dbs(**params) | |||
|
|
|||
| async def info(self): | |||
| return await self._server._get('/') | |||
There was a problem hiding this comment.
Please add an _info() method to RemoteServer and add the @raises decorator for the 401 to that new method. Just like the _check_session method there.
There was a problem hiding this comment.
Oh, and please use " instead of '. That's probably, what the black CI step is complaining about.
Add function to get CouchDB server information (i.e. `GET /`). This
allows, for example, getting the server version with:
couchdb = CouchDB(url)
info = await couchdb.info()
print(info['version'])
adrienverge
force-pushed
the
feat/implement-server-info
branch
from
a652597
to
037b337
Compare
|
I updated the pull request thanks to your suggestion. Here is the diff since last time: --- a/aiocouch/couchdb.py
+++ b/aiocouch/couchdb.py
@@ -41,4 +41,4 @@ class CouchDB(object):
return await self._server._all_dbs(**params)
async def info(self):
- return await self._server._get('/')
+ return await self._server._info()
--- a/aiocouch/remote.py
+++ b/aiocouch/remote.py
@@ -103,6 +103,10 @@ class RemoteServer(object):
await self._http_session.close()
await asyncio.sleep(0.250 if has_ssl_conn else 0)
+ @raises(401, "Invalid credentials")
+ async def _info(self):
+ return await self._get("/")
+
@raises(401, "Authentification failed, check provided credentials.")
async def _check_session(self):
await self._get("/_session") |
bmario
approved these changes
Mar 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add function to get CouchDB server information (i.e.
GET /). Thisallows, for example, getting the server version with: