Dealing with naive datetime objects

[tilsche]

Passing a naive datetime object to Timestamp.from_datetime currently leads to:

    delta = dt - Timestamp._EPOCH
TypeError: can't subtract offset-naive and offset-aware datetimes

Now passing naive objects may be dangerous. And maybe we don't want this. That we need to discuss. I see the following options

• Support both aware and naive datetime objects in from_datetime. In accordance with datetime.timestamp(), assume that naive datetime instances represent local time and use the appropriate mechanisms in datetime.
• Don't support this in from_datetime, but provide a slightly clearer error.
• We could then also add a from_naive_datetime which still allows it, but is more explicit to not make silent mis-assumptions

I tend to the latter variant, but it also bloats up the API somewhat.

I'm currently using

Timestamp.from_posix_seconds(local_begin.timestamp())

which is less than ideal.

Note: the current documentation is already clear, that aware objects are expected.

[tilsche]

I lean towards the third option, but naming it from_local_datetime. And of course also adding better error handling.