Properly parse ISO 8601 date strings to Timestamp #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tilsche
approved these changes
Mar 18, 2021
Let `dateutil.parser.isoparse` [1] do the actual parsing, this is way more robust than anything we could come up with. Now, more timezones than just UTC can be parsed. [1] https://dateutil.readthedocs.io/en/stable/parser.html#dateutil.parser.isoparse
phijor
force-pushed
the
fix-timestamp-iso8601-parsing
branch
from
6c3da0d
to
d553960
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements #7, option 2.