Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add atomic_shim to support platforms without 64-bit atomics #79

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Add atomic_shim to support platforms without 64-bit atomics #79

merged 1 commit into from
Jul 21, 2020

Conversation

nazar554
Copy link
Contributor

atomic-shim does target detection, so it is using std::atomic where possible.
See metrics-rs/quanta#22 and metrics-rs/quanta#23
There are no static AtomicI64/AtomicU64 used so no ctor dependency is needed

@nazar554
Add atomic_shim to support platforms without 64-bit atomics
9e54ef0 
Signed-off-by: Nazar Mishturak <nazarmx@gmail.com>
@tobz tobz merged commit e003dc9 into metrics-rs:master Jul 21, 2020
@tobz
Copy link
Member

tobz commented Jul 21, 2020

metrics-runtime@0.13.1 is now released. Let me know how that works for you. 👍

@nazar554
Copy link
Contributor Author

@tobz Nice, now I can build vector, just need to add the same fix there as well.

mnpw pushed a commit to mnpw/metrics that referenced this pull request Mar 8, 2024
@nazar554
Add atomic_shim to support platforms without 64-bit atomics (metrics-…
111bcfa 
…rs#79)

Signed-off-by: Nazar Mishturak <nazarmx@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nazar554 @tobz