Attempt to bind to the listen address before starting server. #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the Prometheus exporter would bind and serve all in one shot, within a future, which meant users had no way to see if the binding would succeed, and no way to recover the error themselves. This was called out in #83
This PR extracts the binding from the future that we run to drive the exporter, so we can attempt to bind beforehand -- regardless of whether
PrometheusBuilder::installedorPrometheusBuilder::buildis being called -- and let the user know if it succeeded.We've also fixed some other minor nits and cleaned some stuff up.