Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a xax_end_at_max option to complement xax_start_at_min #456

Closed
hampsterx opened this issue Jul 6, 2015 · 8 comments
Closed

Add a xax_end_at_max option to complement xax_start_at_min #456

hampsterx opened this issue Jul 6, 2015 · 8 comments
Milestone

Comments

@hampsterx
Copy link

graph_temp

The default behavior seems to be having the first X axis label using first data point, then a gap, then at the end it runs off the end.

Any idea how to get it to go the other way around, eg first label would be 08:00 (first data point is 08:19) and last point would be 08:05am (ie last data point 08:05)

I have tried the x axis options but cannot seem to get it to do what I want unless I go the full hog and implement xax_format :(

xax_count - the number of x-axis ticks
xax_format - a function that formats the x-axis' labels
x_axis - determines whether to display the x-axis
x_extended_ticks - determines whether to extend the x-axis ticks across the chart
x_label - the label to show below the x-axis
xax_start_at_min - determines whether to start the x-axis from the left-most edge
xax_tick_length - the x-axis' tick length in pixels

@hampsterx
Copy link
Author

ahh my bad, xax_start_at_min was set, causing the first value being used as first Label. Maybe an xax_end_at_max would do it?

@almossawi almossawi added this to the v2.6 milestone Jul 7, 2015
@almossawi almossawi self-assigned this Jul 7, 2015
@almossawi
Copy link
Contributor

Yes, we've had a few requests for that. Targeting v2.6.

@almossawi almossawi changed the title x axis issues Add a xax_end_at_max option to complement xax_start_at_min Jul 7, 2015
@almossawi almossawi modified the milestones: v2.7, v2.6 Jul 8, 2015
@silverwind
Copy link

I've also been looking for such an option. 👍

@brylie
Copy link

brylie commented Oct 1, 2015

From a usability perspective, and in saving people unnecessary strain when reading these charts, it might be worthwhile to enable the start_at_min and end_at_max by default (setting to true).

@almossawi
Copy link
Contributor

@brylie Absolutely: #489

October is the month for getting 2.7 out the door :)

@brylie
Copy link

brylie commented Oct 2, 2015

Cool, are there any 'low hanging fruit' or easy tasks in the 2.7 backlog to which I may contribute?

@almossawi
Copy link
Contributor

@brylie Take your pick :) https://github.com/mozilla/metrics-graphics/issues?q=is%3Aopen+is%3Aissue

Here's the prioritized list, though I suspect several of those unassigned open issues will make it in too: https://github.com/mozilla/metrics-graphics/milestones/v2.7

@almossawi
Copy link
Contributor

See the most recent commit referenced above. The proposed option, axes_not_compact, does away with the need to have to set multiple options and avoids unevenly spaced ticks. It's on by default for now.

screen shot 2015-10-15 at 1 38 58 pm

screen shot 2015-10-15 at 1 39 03 pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants