Building and Testing Fern Definitions #1217

jonahkaye · 2023-11-22T17:20:15Z

Refs: #1212, #1219, #1371

Description

fixing the entire fern definition to make it actually work
writing testing for all three sdks.
moving testers folders into their respective subdirectories in sdk
one or two misc docx bugs fixed.
fern definitions for webhook types too
related to but not dependent on feat(docs): Updating Java Sdk Docs metriport-java#2
merged this PR into mine: 🌿 Metriport Fern Definition exports FHIR schemas #1188
merged this PR into mine: 🌿 Setup Local Java Project to setup Java SDK Testing #1220
merged this PR into mine: [DNM] Add back in fern deps and bump generator versions #1326
merged this PR into mine: Bump Fern dependencies once more for compile fixes #1359

Todo

review fern definitions and fix nits.
fern generator larger changes: FHIR reference and document upload
finish writing tests for python and java
Update docx
integrate fern sdk testing into automatic testing in ci/cd?

Testing

This PR is 99% testing! I put the local testing of fern in each of the respective python, java, typescript folders under in the folder tester-local. Each tester-local roughly has the same tests.
The not local testing of each sdk is more sporadic, which makes sense since the sdks are not deployed. We might want to add an item to the go live to fully test the deployed sdks before sending sdk to customers.
The testing framework for java is a little bit funky. The local testing uses gradle but the testing for the actual sdk uses maven. I used what deep provided since I am really not so familiar with all the piping around running java code.
The not local testing for typescript still uses our current ts-sdk. It makes sense to rewrite this once we have the new ts-sdk deployed.

Note:

If when you look at the tester-local files, you think something should be renamed or a type looks funny, all that is of course changeable
You can build fern and run all local tests by running npm run test-fern-local from oss root

Release Plan

test
merge
proceed with the tasks in go live ticket, which is source of truth for all things Fern rn

Refs: #1212

fern/definition/medical/patient.yml

Refs: #1212

jonahkaye · 2023-11-23T04:56:01Z

docs/medical-api/api-reference/patient/delete-patient.mdx

@@ -6,7 +6,7 @@ api: "DELETE /medical/v1/patient/{id}"

 ## Query Params

-<ParamField query="facilityId" type="string" required>
+<ParamField query="facilityId" type="string" optional>


modified to match endpoint definition.

Refs: #1212

dsinghvi · 2023-11-23T17:20:56Z

@jonahkaye Filed an issue here to track the failing python generator.

Beyond that, the reason fern check is failing is because some of the examples are not correct and you should be able to resolve based on the error messages.

Refs: #1212

refs: #1212

jonahkaye · 2023-11-24T17:58:01Z

fern/definition/medical/fhir.yml

-      docs: Get the status of querying for patient's consolidated data.
-      method: GET
-      path: /patient/{id}/consolidated/query
+    createPatientConsolidated:


added missing endpoint

jonahkaye · 2023-11-24T17:58:26Z

fern/definition/medical/document.yml

@@ -129,12 +136,42 @@ service:
            conversionType: "pdf"
          response:
            body: $DocumentUrl.Example1
+
+    createDocumentReference:


This was a missing endpoint I added

…hir import Refs: #1212

* feat(fhir): reexport fhir types Refs: #1212 --------- Co-authored-by: jonahkaye <70026960+jonahkaye@users.noreply.github.com>

Refs: #1212

*feat(sdks): setup java testing Refs: #1212 --------- Co-authored-by: jonahkaye <70026960+jonahkaye@users.noreply.github.com>

Refs: #1212

Refs: #1296

Refs: #1212

Refs: #1296

Refs: #1212

Refs; #1212

Refs: #1212

jonahkaye · 2024-01-04T05:16:05Z

fern/definition/medical/webhooks.yml

+    - public
+
+  WebhookPatientConsolidatedDataPayload:
+    properties:


I generally just kept the types names as the same ones in the App. Idk if we want to change that

Refs: #1212

jonahkaye

Added webhook types

Refs: #1212

This reverts commit 4e538e6.

Refs: #1212

Goncharo

generally LGTM - conditional approval on the comments getting addressed

fern/definition/medical/document.yml

fern/definition/medical/fhir.yml

fern/definition/medical/patient.yml

Refs: #1212

github-actions · 2024-02-13T14:53:13Z

🎉 This PR is included in version 5.59.0-develop.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

github-actions · 2024-02-13T16:46:36Z

🎉 This PR is included in version 5.60.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

jonahkaye added 7 commits November 22, 2023 11:35

feat(sdk): java tests move and first test rewritten

e3d3964

Refs: #1212

feat(sdk): create facility

4019e89

Refs: #1212

feat(sdk): waiting on contacts definition release

a017b8f

Refs: #1212

Merge branch 'develop' into 1212-test-migration-python-sdk-tests

cd178b0

feat(sdk): yaml def changes and get,post working

e080497

Refs: #1212

feat(sdk): yaml def changes and get,post working

d1caa48

Refs: #1212

feat(sdk): updating defiitions

5dde81d

Refs: #1212

dsinghvi reviewed Nov 23, 2023

View reviewed changes

fern/definition/medical/patient.yml Outdated Show resolved Hide resolved

feat(sdk): updating defiitions

b0e540d

Refs: #1212

jonahkaye commented Nov 23, 2023

View reviewed changes

jonahkaye added 2 commits November 23, 2023 00:46

feat(sdks): requestdd for documentquery in fern

609f3a4

Refs: #1212

feat(sdks): list document request update fern

c725147

Refs: #1212

jonahkaye changed the title ~~feat(sdk): Writing Java and Python Tests and Moving testers into sdk~~ feat(sdk): Validating and Testing Fern Definitions Nov 23, 2023

jonahkaye added 2 commits November 24, 2023 12:08

feat(sdks): update document reference, createDocumentReference endpoint

cb88978

Refs: #1212

feat(sdks): compiling

ff95013

refs: #1212

jonahkaye commented Nov 24, 2023

View reviewed changes

jonahkaye and others added 3 commits November 24, 2023 14:01

feat(sdks): testing changes complete. waiting on bug resolution and f…

46d8f9c

…hir import Refs: #1212

🌿 Metriport Fern Definition exports FHIR schemas (#1188)

4652dc3

* feat(fhir): reexport fhir types Refs: #1212 --------- Co-authored-by: jonahkaye <70026960+jonahkaye@users.noreply.github.com>

feat(sdks): merged deeps changes

cb117bd

Refs: #1212

jonahkaye self-assigned this Nov 27, 2023

jonahkaye and others added 4 commits November 27, 2023 15:42

feat(sdks): update reqs

e227774

Refs: #1212

Merge branch 'develop' into 1212-test-migration-python-sdk-tests

39fd99e

🌿 Setup Local Java Project to setup Java SDK Testing (#1220)

df2433b

*feat(sdks): setup java testing Refs: #1212 --------- Co-authored-by: jonahkaye <70026960+jonahkaye@users.noreply.github.com>

feat(sdks): organizing things properly

eb51d87

Refs: #1212

leite08 force-pushed the develop branch from 96f6c25 to 6a343ca Compare November 30, 2023 18:22

jonahkaye added 3 commits November 30, 2023 15:38

feat(sdks): removing fhir

d6d92d7

Refs: #1296

feat(sdks): merging w/ develop

2fd0655

Refs: #1212

feat(sdk): java code

f833366

Refs: #1296

jonahkaye requested review from Orta21 and RamilGaripov as code owners December 22, 2023 04:31

jonahkaye added 5 commits December 22, 2023 09:43

feat(sdks): scripts for easy running

7cb53c9

Refs: #1212

feat(sdks): fern gen in script

6cbfb97

Refs: #1212

feat(sdks): rebasing

fb4ac8d

Refs: #1212

feat(sdks): webhook types

d532230

Refs; #1212

feat(sdks): validating first webhook def

d134716

Refs: #1212

jonahkaye commented Jan 4, 2024

View reviewed changes

feat(sdks): readme

3792b1a

Refs: #1212

jonahkaye commented Jan 4, 2024

View reviewed changes

jonahkaye added 9 commits January 4, 2024 00:46

feat(sdks): bundle extension deep pls take a look

6576526

Refs: #1212

feat(sdks): resource not defined error

13299bf

Refs: #1212

feat(sdk): debugging with deep and handoff

4e538e6

Refs: #1212

Revert "feat(sdk): debugging with deep and handoff"

fa8e6ac

This reverts commit 4e538e6.

feat(sdks): fixed node webhook types

e89bf68

Refs: #1212

Merge branch 'develop' into 1212-test-migration-python-sdk-tests

92be8cd

Merge branch 'develop' into 1212-test-migration-python-sdk-tests

84b6d07

feat(sdks): pairing with ramil for his pr for fern

99e288e

Refs: #1212

feat(sdks): merging develop to branch

9f4a0ac

Refs: #1212

Goncharo approved these changes Feb 11, 2024

View reviewed changes

jonahkaye added 2 commits February 12, 2024 22:13

feat(sdks): responding to nits

ec5c1c4

Refs: #1212

Merge branch 'develop' into 1212-test-migration-python-sdk-tests

90dd1eb

jonahkaye merged commit 715ebb9 into develop Feb 13, 2024
3 checks passed

jonahkaye deleted the 1212-test-migration-python-sdk-tests branch February 13, 2024 03:31

jonahkaye changed the title ~~feat(sdk): Validating and Testing Fern Definitions~~ Building and Testing Fern Definitions Feb 13, 2024

jonahkaye mentioned this pull request Feb 13, 2024

RELEASE 2024_02_12 #1609

Merged

1 task

github-actions bot added the released on @develop label Feb 13, 2024

github-actions bot added the released label Feb 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Building and Testing Fern Definitions #1217

Building and Testing Fern Definitions #1217

jonahkaye commented Nov 22, 2023 •

edited

jonahkaye Nov 23, 2023 •

edited

dsinghvi commented Nov 23, 2023

jonahkaye Nov 24, 2023

jonahkaye Nov 24, 2023

jonahkaye Jan 4, 2024

jonahkaye left a comment

Goncharo left a comment

github-actions bot commented Feb 13, 2024

github-actions bot commented Feb 13, 2024

Building and Testing Fern Definitions #1217

Building and Testing Fern Definitions #1217

Conversation

jonahkaye commented Nov 22, 2023 • edited

Description

Todo

Testing

Note:

Release Plan

jonahkaye Nov 23, 2023 • edited

Choose a reason for hiding this comment

dsinghvi commented Nov 23, 2023

jonahkaye Nov 24, 2023

Choose a reason for hiding this comment

jonahkaye Nov 24, 2023

Choose a reason for hiding this comment

jonahkaye Jan 4, 2024

Choose a reason for hiding this comment

jonahkaye left a comment

Choose a reason for hiding this comment

Goncharo left a comment

Choose a reason for hiding this comment

github-actions bot commented Feb 13, 2024

github-actions bot commented Feb 13, 2024

jonahkaye commented Nov 22, 2023 •

edited

jonahkaye Nov 23, 2023 •

edited