Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IHE gateway v2: adding support for telecoms, ssns, multiple names and addresses + adding types #2143

Merged
merged 15 commits into from
May 30, 2024

Conversation

jonahkaye
Copy link
Member

@jonahkaye jonahkaye commented May 23, 2024

Ticket: #1667

Description

  • updating ihe-gateway-sdk to accept telecoms and identifiers
  • updating ihe gateway v2 to find telecoms
  • updating ihe gateway v2 to use all telecoms and all addresses and all patient names and ssns (BUG BUG BUG)
  • adding types
  • reverting Redox specific logic to use request Home Community Id

Testing

  • Local
    • unit testing
    • endpoints
  • Staging
    • branch to staging
    • test on staging

Release Plan

  • Merge this

Refs: #1667
Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>
@jonahkaye jonahkaye changed the base branch from develop to patch-bad-patient-demo-parsing May 23, 2024 20:26
Base automatically changed from patch-bad-patient-demo-parsing to develop May 23, 2024 22:18
@jonahkaye jonahkaye self-assigned this May 24, 2024
const patientBirthtime = bodyData.patientResource.birthDate?.replace(DATE_DASHES_REGEX, "");
const patientName = bodyData.patientResource.name;
const patientAddress = bodyData.patientResource.address;
const patientTelecom = bodyData.patientResource.telecom;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we havent been using all the patients addresses or names, and havent been using their telecoms!

Refs: #1667
Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>
Refs: #1667
Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>
Refs: #1667
Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>
Refs: #1677
Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>
Refs: #1667
Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redox endpoints actually do want the home community id of the response and not the request. I misunderstood this before, possibly because PCC works with both, while the other 2 redox endpoints only work with the response home community id.

This was clarified over slack with redox technical support

Refs: #1667
Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverting redox specific logic

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reverting redox specific logic

patientResource: z
.any()
.refine(value => value !== undefined, { message: "patientResource is required" }),
patientResource: patientResourceSchema,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding typing

Refs: #1667
Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>
@jonahkaye jonahkaye changed the title 1667 telecom ids IHE gateway v2: adding support for telecoms, ssns, multiple names and addresses + adding types May 27, 2024
@jonahkaye jonahkaye marked this pull request as ready for review May 27, 2024 16:24
Refs: #1667
Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>
Refs: #1667
Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>
Copy link
Member Author

@jonahkaye jonahkaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is what the xml looks like if identifier, address, telecom are empty:

<urn:parameterList>
    <urn:livingSubjectAdministrativeGender>
        <urn:value code= \"M\" codeSystem= \"2.16.840.1.113883.5.1\" />
        <urn:semanticsText>LivingSubject.administrativeGender</urn:semanticsText>
    </urn:livingSubjectAdministrativeGender>
    <urn:livingSubjectName>
        <urn:value>
            <urn:given>hi
            <urn:given>hello
            <urn:family>me
        </urn:value>
        <urn:semanticsText>LivingSubject.name</urn:semanticsText>
    </livingSubjectName>
    <urn:livingSubjectBirthTime>
        <urn:value value= \"19810101\" />
      <urn:semanticsText>LivingSubject.birthTime</urn:semanticsText>
    </urn:livingSubjectBirthTime>
    <urn:livingSubjectId />
    <urn:patientAddress />
    <urn:patientTelecom />
    <urn:principalCareProviderId>
        <urn:value extension= \"1234567890\" root= \"2.16.840.1.113883.4.6\" />
        <urn:semanticsText>AssignedProvider.id</urn:semanticsText>
    </urn:principalCareProviderId>
</urn:parameterList>

Refs: #1667
Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>
Refs: #1667
Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>
Refs: #1667
Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>
Copy link
Member

@leite08 leite08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see there's NPM package publishing on the plan for this PR, but no publishing was done.

OTOH, it seems we don't need it since all dependencies w/ the exception of carequality-cert-runner are direct, not through NPM (we should prob discuss whether we want to keep publishing this):

image

@jonahkaye jonahkaye added this pull request to the merge queue May 30, 2024
Merged via the queue into develop with commit 1a6becb May 30, 2024
14 checks passed
@jonahkaye jonahkaye deleted the 1667-telecom-ids branch May 30, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants