-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IHE gateway v2: adding support for telecoms, ssns, multiple names and addresses + adding types #2143
Conversation
Refs: #1667 Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>
Refs: #1667 Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>
const patientBirthtime = bodyData.patientResource.birthDate?.replace(DATE_DASHES_REGEX, ""); | ||
const patientName = bodyData.patientResource.name; | ||
const patientAddress = bodyData.patientResource.address; | ||
const patientTelecom = bodyData.patientResource.telecom; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we havent been using all the patients addresses or names, and havent been using their telecoms!
Refs: #1667 Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>
Refs: #1667 Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>
Refs: #1667 Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>
Refs: #1677 Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>
Refs: #1667 Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Redox endpoints actually do want the home community id of the response and not the request. I misunderstood this before, possibly because PCC works with both, while the other 2 redox endpoints only work with the response home community id.
This was clarified over slack with redox technical support
Refs: #1667 Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverting redox specific logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reverting redox specific logic
packages/core/src/external/carequality/ihe-gateway-v2/outbound/xcpd/create/iti55-envelope.ts
Show resolved
Hide resolved
patientResource: z | ||
.any() | ||
.refine(value => value !== undefined, { message: "patientResource is required" }), | ||
patientResource: patientResourceSchema, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adding typing
Refs: #1667 Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>
Refs: #1667 Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>
packages/core/src/external/carequality/ihe-gateway-v2/gateways.ts
Outdated
Show resolved
Hide resolved
packages/core/src/external/carequality/ihe-gateway-v2/outbound/xcpd/create/iti55-envelope.ts
Show resolved
Hide resolved
packages/core/src/external/carequality/ihe-gateway-v2/outbound/xcpd/create/iti55-envelope.ts
Show resolved
Hide resolved
packages/core/src/external/carequality/ihe-gateway-v2/outbound/xcpd/create/iti55-envelope.ts
Show resolved
Hide resolved
packages/core/src/external/carequality/ihe-gateway-v2/outbound/xcpd/create/iti55-envelope.ts
Outdated
Show resolved
Hide resolved
packages/core/src/external/carequality/ihe-gateway-v2/outbound/xcpd/process/xcpd-response.ts
Show resolved
Hide resolved
packages/core/src/external/carequality/ihe-gateway-v2/outbound/xcpd/process/xcpd-response.ts
Show resolved
Hide resolved
packages/core/src/external/carequality/ihe-gateway-v2/saml/__tests__/constants.ts
Show resolved
Hide resolved
packages/ihe-gateway-sdk/src/models/patient-discovery/patient-discovery-responses.ts
Show resolved
Hide resolved
Refs: #1667 Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what the xml looks like if identifier, address, telecom are empty:
<urn:parameterList>
<urn:livingSubjectAdministrativeGender>
<urn:value code= \"M\" codeSystem= \"2.16.840.1.113883.5.1\" />
<urn:semanticsText>LivingSubject.administrativeGender</urn:semanticsText>
</urn:livingSubjectAdministrativeGender>
<urn:livingSubjectName>
<urn:value>
<urn:given>hi
<urn:given>hello
<urn:family>me
</urn:value>
<urn:semanticsText>LivingSubject.name</urn:semanticsText>
</livingSubjectName>
<urn:livingSubjectBirthTime>
<urn:value value= \"19810101\" />
<urn:semanticsText>LivingSubject.birthTime</urn:semanticsText>
</urn:livingSubjectBirthTime>
<urn:livingSubjectId />
<urn:patientAddress />
<urn:patientTelecom />
<urn:principalCareProviderId>
<urn:value extension= \"1234567890\" root= \"2.16.840.1.113883.4.6\" />
<urn:semanticsText>AssignedProvider.id</urn:semanticsText>
</urn:principalCareProviderId>
</urn:parameterList>
Refs: #1667 Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>
packages/ihe-gateway-sdk/src/models/patient-discovery/patient-discovery-responses.ts
Show resolved
Hide resolved
packages/ihe-gateway-sdk/src/models/patient-discovery/patient.ts
Outdated
Show resolved
Hide resolved
packages/core/src/external/carequality/ihe-gateway-v2/outbound/xcpd/process/xcpd-response.ts
Show resolved
Hide resolved
packages/core/src/external/carequality/ihe-gateway-v2/outbound/__tests__/xmls/xcpd_match.xml
Show resolved
Hide resolved
packages/core/src/external/carequality/ihe-gateway-v2/outbound/xcpd/create/iti55-envelope.ts
Show resolved
Hide resolved
Refs: #1667 Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>
packages/ihe-gateway-sdk/src/models/patient-discovery/patient.ts
Outdated
Show resolved
Hide resolved
packages/core/src/external/carequality/ihe-gateway-v2/outbound/xcpd/process/xcpd-response.ts
Outdated
Show resolved
Hide resolved
packages/core/src/external/carequality/ihe-gateway-v2/outbound/xcpd/process/xcpd-response.ts
Outdated
Show resolved
Hide resolved
packages/core/src/external/carequality/ihe-gateway-v2/outbound/xcpd/process/xcpd-response.ts
Outdated
Show resolved
Hide resolved
packages/core/src/external/carequality/pd/process-inbound-pd.ts
Outdated
Show resolved
Hide resolved
packages/ihe-gateway-sdk/src/models/patient-discovery/patient.ts
Outdated
Show resolved
Hide resolved
Refs: #1667 Signed-off-by: Jonah Kaye <jonah.arturo@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ticket: #1667
Description
Testing
Release Plan