Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing card images #199

Closed
2 of 20 tasks
micolous opened this issue Oct 4, 2018 · 5 comments
Closed
2 of 20 tasks

Add missing card images #199

micolous opened this issue Oct 4, 2018 · 5 comments
Milestone
2.9.38

Comments

@micolous
Copy link
Collaborator

micolous commented Oct 4, 2018 •
edited

Description of the issue

Missing card images added in other pull requests:

  • Ventra (Chicago, IL, USA)
  • Trimet (Portland, OR, USA)
  • Viva (Lisboa, Portugal)
  • Envibus (France)
  • Navigo (France)
  • OùRA (France)
  • TaM (France)
  • Transgironde (France)
  • Mobib (Belgium)
  • RicaricaMi (Italy)
  • Adelaide Metro
  • Beijing
  • City Union
  • Pastel (France)
  • Kiev
  • MetroQ (Houston)
  • Selecta (France)
  • SunCard (Orlando)
  • Tartu Bus
  • Wuhan Tong
@micolous micolous added this to the 2.9.36 milestone Oct 4, 2018
@micolous micolous mentioned this issue Oct 4, 2018
Closed
micolous added a commit that referenced this issue Oct 6, 2018
@micolous
Add MOBIB card image (#199)
923d2ea
micolous added a commit that referenced this issue Oct 6, 2018
@micolous
Add TriMetHop image (#199)
a67234a
@micolous micolous modified the milestones: 2.9.36, 2.9.37 Oct 6, 2018
@micolous
Copy link
Collaborator Author

micolous commented Oct 6, 2018

Finding good quality images of some of these cards has been hard. I'm going to leave it as is and pick up the remaining cards in a future release.

micolous added a commit that referenced this issue Nov 11, 2018
@micolous
Add custom linter checks, warn when there are missing card images (#199)
a263b1a
@micolous micolous modified the milestones: 2.9.37, 2.9.38 Dec 23, 2018
@phcoder
Copy link
Collaborator

phcoder commented Jun 15, 2019

All of this except CityUnion either have been added or in Pull requests queue.
In all currently missing are: City Union, Magna Carta and Intercard

@phcoder
Copy link
Collaborator

phcoder commented Jun 16, 2019

CityUnion is in PR as well

@phcoder
Copy link
Collaborator

phcoder commented Jun 16, 2019

MagnaCarta and Intercard as well (it's logos and not individual cards)

@phcoder
Copy link
Collaborator

phcoder commented Jun 24, 2019

This can be closed

@micolous micolous closed this as completed Jul 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.9.38
Development

No branches or pull requests
2 participants
@phcoder @micolous