Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run log should store model objects as a column for further interaction(s) #93

Open
dpastoor opened this issue Jun 15, 2020 · 2 comments
Labels
enhancement New feature or request risk: low

Comments

@dpastoor
Copy link
Contributor

case: user calls runlog to aggregate all models - they then want to extract key information out of model(s). Currently this could be done something along the lines of:

run_log() %>% pull(absolute_model_path) 
%>% map_df(~ read_model(.x) %>% model_summary()
)

In this case, the model yaml needs to be double processed. Its not that much time, however given the case of multiple pipes or otherwise could add up unnecessarily.

New:

run_log() %>% pull(.mod) %>% 
%>% map_df(~ .x %>% model_summary()
)

Better new given model_summary can handle vector/list of model objects:

run_log() %>% pull(.mod) %>% model_summary()
@seth127
Copy link
Collaborator

seth127 commented Sep 21, 2020

Having the model object as a column in run_log() output could still be useful in theory, but the use case described here is solved by #29

Worth noting though, the summary_log() output does contain the full bbi_nonmem_summary object in it's own column, which is analogous to the proposed change here. Just pointing out that we do support this pattern elsewhere so maybe it makes sense to do it here too, for the sake of consistency.

@seth127 seth127 added enhancement New feature or request risk: low labels Sep 21, 2020
@seth127
Copy link
Collaborator

seth127 commented Sep 24, 2020

Would be able to simplify model_summaries.bbi_run_log_df dispatch if we did this.
https://github.com/metrumresearchgroup/rbabylon/blob/develop/R/model-summaries.R#L113 if we did this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request risk: low
Projects
None yet
Development

No branches or pull requests

2 participants