[Feature] Upgrade Package Support To Laravel 8 #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This moves us to L8. Most of the work has been put into making the tests pass, as we have moved to using the new, "improved" factories, rather than add the legacy factories package. Additionally we have moved models to a `Models` namespace, to be in line with how a new L8 project is structured in that regard.
mauricius
reviewed
Jan 26, 2021
mauricius
reviewed
Jan 26, 2021
mauricius
approved these changes
Jan 26, 2021
- Remove phpunit.xml.bak - Remove commented out code in TestCase.php
rockbuzz
pushed a commit
to rockbuzz/sendportal
that referenced
this pull request
Jan 29, 2022
* Upgrade to Laravel 8 This moves us to L8. Most of the work has been put into making the tests pass, as we have moved to using the new, "improved" factories, rather than add the legacy factories package. Additionally we have moved models to a `Models` namespace, to be in line with how a new L8 project is structured in that regard. * Make changes based on review - Remove phpunit.xml.bak - Remove commented out code in TestCase.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves us to L8. Most of the work has been put into making the tests pass, as we have moved to using the new, "improved" factories, rather than add the legacy factories package.
Additionally we have moved models to a
Modelsnamespace, to be in line with how a new L8 project is structured in that regard.