[Feature] Automatic Invitation Acceptance For Existing Users #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was prompted by an issue where users who are only in the system via an invitation, who subsequently get removed from the workspace they were invited to, were unable to access the application at all to either create their own workspace or accept an invitation to another existing one. By automatically accepting invitations that are made to existing users, we avoid having to do things like deleting users if they have no workspace, or adjusting the system so that it workspaceless users can access workspace management features to create or accept invitations to workspaces. Additionally, this removes friction from adding users to new workspaces in any given SendPortal instance. It seems unlikely that someone would actually want to reject an invitation, given that it is a self-hosted platform. The ability to manually accept invitations has not been removed, as there may be cases where invitations already exist that haven't yet been handled.
This rewords the invitation email to remove the reference to needing to log in and accept (or reject) the invitation. Additionally, because we already had HTML tags in place, this replaces using <br><br> with paragraph tags.
rockbuzz
pushed a commit
to rockbuzz/sendportal
that referenced
this pull request
Jan 29, 2022
…n-acceptance [Feature] Automatic Invitation Acceptance For Existing Users
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was prompted by Issue #126, where users who are only in the system
via an invitation, who subsequently get removed from the workspace they
were invited to, were unable to access the application at all to either
create their own workspace or accept an invitation to another existing
one.
By automatically accepting invitations that are made to existing users,
we avoid having to do things like deleting users if they have no
workspace, or adjusting the system so that it workspaceless users can
access workspace management features to create or accept invitations to
workspaces.
Additionally, this removes friction from adding users to new workspaces
in any given SendPortal instance. It seems unlikely that someone would
actually want to reject an invitation, given that it is a self-hosted
platform.
The ability to manually accept invitations has not been removed, as
there may be cases where invitations already exist that haven't yet
been handled.