Cwd #7
Merged
Cwd #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 14, 2018 19:07
Rationnal:
==========
I found myself writing code like this:
shell = LocalShell()
os.chdir(first_custom_path)
shell('first_command')
os.chdir(second_custom_path)
shell('second_command')
I didn't like it!
Shell is built upon Popen.
It's cwd paramater allows to set a custom path.
With this option avalaible on LocalShell object,
I can then change the code to:
shell = LocalShell()
shell('first_command', cwd=first_custom_path)
shell('second_command', cwd=second_custom_path)
Better ;-)
Remark:
======
I was tempted to make cwd persitant so that code like this:
shell = LocalShell(cwd=custom_path)
shell('first_command')
shell('second_command')
runs commands in "custom_path".
But I find it a bit hard to read.
I will have to go back and forth from object instantiation to shell command
to figure out from where those are run.
So I didn't go any further this way!
|
Hi Yves, Thanks for the PR! I merged it, extended it so that cwd is also available in other kinds of shell. This is now included in the latest release (v2.2.0), If you encounter any issue, let me know -Cédric |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Cédric,
I would like that "cwd" parameter from Popen be available for LocalShell objects.
This enhances code readability.
Regards,
Yves