Bug in beforehandler, on deleting multiple rows

[BarryDam]

Hi there,

We're allmost there, I found 2 bugs, one I solved with this pull request:

The first one: on deleting multiple rows at once and applying my soft delete see example 209 I got an 404 errror : Subject caused by the updateObject method

The other you will find here 209, this needs to be discussed first.

[mevdschee]

Can you verify that the "deleting multiple rows issue" still exists in v1.0.9?

[BarryDam]

Nope it still throws "Not found (subject) " since the $inputs holds only 1 object.. and it should be multiple on a multiple deletion

[mevdschee]

Ah.. I get it.. so you should really modify inputs so that it holds multiple values.

$inputs = array_map(function($v){
  return (object)array('deleted'=>date('Y-m-d H:i:s', time());
},explode(',',$id));

Something like that?

[BarryDam]

Uh yes I guess,:

when you do

DELETE http://localhost/api.php/categories/1,2

In the current situation

'before'=>function(&$cmd, &$db, &$tab, &$id, &$in) {  }

$id = '1,2'; and the $in parameter holds an array with ONE object.

which shoud be 2 objects.. one for $id 1 and one for $id 2..

since in the updateObject method you check the $inputs count agains the multiple count..

(count($inputs)!=count($keys))

Which in the current situation would evaluate to (1!-2) which will throw the error

[mevdschee]

So, shouldn't we just change the example?

[BarryDam]

... uhhhhh .. .well ... not really sure..

first off, I think the functionality for the end user should be as "easy to use" as possible... now the end user has to do something that feels complex in my opinion.

Second.. on a multiple deletion the $in param has one object.. which has no use at all.. so it either holds 2 values (on 2 deletions), or null., since you can't do anything with it...
In comparison with a before multiple (2) update cmd.. the $in param will also hold 2 objects..

Also I found another bug this foreach wil overwrite the inputs returned by applyBeforeHandler..

it will kick out de delete column since $fields does not have this column

[BarryDam]

Makes me think, wouldn't it be better .. if on a multiple Update (or other command).. for example

PUT http://localhost/api.php/categories/1,2
[{"name":"Internet"},{"name":"Programming"}]

the "before" => function() { ... } would get called twice

first time

'before'=>function(&$cmd, &$db, &$tab, &$id, &$in) {  
$id; // 1
$in; //{"name":"Internet"}
}

second time
first time

'before'=>function(&$cmd, &$db, &$tab, &$id, &$in) {  
$id; // 2
$in; //{"name":"Programming"}
}

Makes it more end user friendly, also the end user will have the same expectations as if it would be only 1 update.

[mevdschee]

I agree, I was doubting whether or not that would be a good idea, maybe it is indeed..

[BarryDam]

I think it is! And maybe this would also be better for the after callback.. .

[BarryDam]

like this?

Includes the multiple before call and fix for : "
Also I found another bug this foreach wil overwrite the inputs returned by applyBeforeHandler..
"

[mevdschee]

Thank you. I did some refactoring in 919e820

[mevdschee]

Can you verify that the issue is gone in v1.1.3?

[BarryDam]

No it's not, see #212