Sample with Rice parameter escape codes

[0xbzho]

invalid-residual.flac.zip

This triggered:

frame.Subframe.decodeRicePart: The flac library test cases do not yet include any audio files with Rice parameter escape codes. If possible please consider contributing this audio sample to improve the reliability of the test cases.

The sample is a corruption of https://freesound.org/people/krestivo/sounds/27951/

[mewmew]

@0xbzho thanks for sending the sample that triggered this code path. Just to clarify, is the sample a valid FLAC file? Or a corrupted one? If the latter, an error from the library is to be expected.

Cheers,
Robin

[0xbzho]

It's corrupted. I assumed you wanted valid and invalid samples for the code path. :-)

[mewmew]

It's corrupted. I assumed you wanted valid and invalid samples for the code path. :-)

That's fair. For now, we'll only rely on valid FLAC test cases. Thanks for submitting the issue none-the-less. If you do come across a valid FLAC file with Rice parameter escape codes, please do submit them to us :)

Cheers
Robin

[wader]

It looks like escape coding was dropped in version 1.2.0 (xiph/flac@3b5f471) of the official flac encoding so maybe possible to build a version previous to that and generate a test file?

[mewmew]

It looks like escape coding was dropped in version 1.2.0 (xiph/flac@3b5f471) of the official flac encoding so maybe possible to build a version previous to that and generate a test file?

Ah, ok. Good to know. I think I'm fine with having it as is until there are users with real world FLAC files having these escape codes. If the latest version of the official flac does not generate these we probably won't see many new flac files being produces with escape codes.

Cheers,
Robin

P.S. thanks @wader for looking into this issue :)