Include keys as attributes returned by __dir__() #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @Who8MyLunch, thanks for submitting this! 👍 Could you take a moment and update the failing test? |
|
The failing test has been updated to reflect the new dir behavior. Pierre Villeneuve On Tue, Mar 10, 2015 at 2:39 PM, Mats Julian Olsen <notifications@github.com
|
|
Cool beans :) |
|
I think this looks good! Thanks @Who8MyLunch for contributing, I hope you continue to do it! Feel free to contribute with ideas to #26. This fixes #45. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to dir method to address issues with autocomplete on Dict keys. See #45 for details.