Apply some ignored eslint rules

__tests__/TestData.ts

@@ -2,7 +2,7 @@
 // I want to reformat these arrays as tables but I have no idea how
 // to do it automatically, and I'm sure not doing it manually.
 
-var validSignal = new Float32Array([
+const validSignal = new Float32Array([
   0.210053,
   0.177877,
   0.164105,
@@ -517,7 +517,7 @@ var validSignal = new Float32Array([
   -0.0591427,
 ]);
 
-var validAmpSpec = new Float32Array([
+const validAmpSpec = new Float32Array([
   0.19665084779262543,
   0.2347041368484497,
   0.8820229172706604,
@@ -776,7 +776,7 @@ var validAmpSpec = new Float32Array([
   0.00631281454116106,
 ]);
 
-var validFFT = {
+const validFFT = {
   real: new Float32Array([
     -0.19665084779262543,
     -0.19752468168735504,
@@ -1808,7 +1808,7 @@ var validFFT = {
   length: 512,
 };
 
-var expectedPowerSpectrumOutput = new Float32Array([
+const expectedPowerSpectrumOutput = new Float32Array([
   0.03867155686020851,
   0.055086031556129456,
   0.7779644131660461,
@@ -2067,7 +2067,7 @@ var expectedPowerSpectrumOutput = new Float32Array([
   0.00003985162766184658,
 ]);
 
-var barkScale = new Float32Array([
+const barkScale = new Float32Array([
   0,
   0.8502324223518372,
   1.694183111190796,

__tests__/exports-node.ts

@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/no-var-requires */
 /**
  * This is required to trick typescript into thinking this file is a module
  * rather than a script. If this file is a script, it won't get its own scope
@@ -29,7 +30,7 @@ const EXPECTED_EXPORTS = [
 
 describe("package exports", () => {
   test("meyda node exports at least currently expected fields", () => {
-    var meyda = require("../dist/node/main");
+    const meyda = require("../dist/node/main");
 
     expect(Object.keys(meyda)).toEqual(EXPECTED_EXPORTS);
   });

__tests__/exports-web.ts

@@ -1,6 +1,7 @@
 /**
  * @jest-environment jsdom
  */
+/* eslint-disable @typescript-eslint/no-var-requires */
 
 /**
  * This is required to trick typescript into thinking this file is a module
@@ -34,7 +35,7 @@ const EXPECTED_EXPORTS = [
 describe("package exports", () => {
   test("meyda web exports at least currently expected fields", () => {
     expect(window["Meyda"]).not.toBeDefined();
-    var meyda = require("../dist/web/meyda");
+    const meyda = require("../dist/web/meyda");
 
     expect(Object.keys(meyda)).toEqual(EXPECTED_EXPORTS);
     expect(Object.keys(window["Meyda"])).toEqual(EXPECTED_EXPORTS);
@@ -44,7 +45,7 @@ describe("package exports", () => {
 
   test("meyda web min exports at least currently expected fields", () => {
     expect(global["Meyda"]).not.toBeDefined();
-    var meyda = require("../dist/web/meyda.min");
+    const meyda = require("../dist/web/meyda.min");
 
     expect(Object.keys(meyda)).toEqual(EXPECTED_EXPORTS);
     expect(Object.keys(global["Meyda"])).toEqual(EXPECTED_EXPORTS);
@@ -55,7 +56,7 @@ describe("package exports", () => {
 
 describe("package exports", () => {
   test("meyda node exports at least currently expected fields", () => {
-    var meyda = require("../dist/node/main");
+    const meyda = require("../dist/node/main");
 
     expect(Object.keys(meyda)).toEqual(EXPECTED_EXPORTS);
     expect(Object.keys(global["Meyda"])).toEqual(EXPECTED_EXPORTS);

__tests__/extractors/chroma.ts

@@ -1,19 +1,19 @@
 import TestData from "../TestData";
-var utilities = require("../../dist/node/utilities");
+import * as utilities from "../../dist/node/utilities";
 
 // Setup
-var chroma = require("../../dist/node/extractors/chroma");
+import chroma from "../../dist/node/extractors/chroma";
 
 describe("chroma", () => {
   test("should return correct chroma value given a valid signal", (done) => {
-    var chromagram = chroma({
+    const chromagram = chroma({
       sampleRate: 44100,
       bufferSize: 512,
       ampSpectrum: TestData.VALID_AMPLITUDE_SPECTRUM,
       chromaFilterBank: utilities.createChromaFilterBank(12, 44100, 512),
     });
 
-    for (var i in TestData.EXPECTED_CHROMAGRAM_OUTPUT) {
+    for (const i in TestData.EXPECTED_CHROMAGRAM_OUTPUT) {
       expect(
         Math.abs(chromagram[i] - TestData.EXPECTED_CHROMAGRAM_OUTPUT[i])
       ).toBeLessThanOrEqual(1e-5);
@@ -24,23 +24,26 @@ describe("chroma", () => {
 
   test("should throw an error when passed an empty object", (done) => {
     try {
-      var chromagram = chroma({});
+      const chromagram = chroma({});
+      chromagram;
     } catch (e) {
       done();
     }
   });
 
   test("should throw an error when not passed anything", (done) => {
     try {
-      var chromagram = chroma();
+      const chromagram = chroma();
+      chromagram;
     } catch (e) {
       done();
     }
   });
 
   test("should throw an error when passed something invalid", (done) => {
     try {
-      var chromagram = chroma({ ampSpectrum: "not a signal" });
+      const chromagram = chroma({ ampSpectrum: "not a signal" });
+      chromagram;
     } catch (e) {
       done();
     }

__tests__/extractors/energy.ts

@@ -1,11 +1,11 @@
 import TestData from "../TestData";
 
 // Setup
-var energy = require("../../dist/node/extractors/energy");
+import energy from "../../dist/node/extractors/energy";
 
 describe("energy", () => {
   test("should return the correct value given a valid signal", (done) => {
-    var en = energy({
+    const en = energy({
       signal: TestData.VALID_SIGNAL,
     });
 
@@ -16,23 +16,26 @@ describe("energy", () => {
 
   test("should throw an error when passed an empty object", (done) => {
     try {
-      var en = energy({});
+      const en = energy({});
+      en;
     } catch (e) {
       done();
     }
   });
 
   test("should throw an error when not passed anything", (done) => {
     try {
-      var en = energy();
+      const en = energy();
+      en;
     } catch (e) {
       done();
     }
   });
 
   test("should throw an error when passed something invalid", (done) => {
     try {
-      var en = energy({ signal: "not a signal" });
+      const en = energy({ signal: "not a signal" });
+      en;
     } catch (e) {
       done();
     }

__tests__/extractors/loudness.ts

@@ -1,11 +1,11 @@
 import TestData from "../TestData";
 
 // Setup
-var loudness = require("../../dist/node/extractors/loudness");
+import loudness from "../../dist/node/extractors/loudness";
 
 describe("loudness", () => {
   test("should return correct value given a valid signal", (done) => {
-    var en = loudness({
+    const en = loudness({
       ampSpectrum: TestData.VALID_AMPLITUDE_SPECTRUM,
       barkScale: TestData.VALID_BARK_SCALE,
     });
@@ -29,23 +29,26 @@ describe("loudness", () => {
 
   test("should throw an error when passed an empty object", (done) => {
     try {
-      var en = loudness({});
+      const en = loudness({});
+      en;
     } catch (e) {
       done();
     }
   });
 
   test("should throw an error when not passed anything", (done) => {
     try {
-      var en = loudness();
+      const en = loudness();
+      en;
     } catch (e) {
       done();
     }
   });
 
   test("should throw an error when passed something invalid", (done) => {
     try {
-      var en = loudness({ signal: "not a signal" });
+      const en = loudness({ signal: "not a signal" });
+      en;
     } catch (e) {
       done();
     }

__tests__/extractors/mfcc.ts

@@ -1,12 +1,12 @@
 import TestData from "../TestData";
-var utilities = require("../../dist/node/utilities");
+import * as utilities from "../../dist/node/utilities";
 
 // Setup
-var mfcc = require("../../dist/node/extractors/mfcc");
+import mfcc from "../../dist/node/extractors/mfcc";
 
 describe("mfcc", () => {
   test("should return correct mfcc value given a valid signal", (done) => {
-    var en = mfcc({
+    const en = mfcc({
       sampleRate: 44100,
       bufferSize: 512,
       ampSpectrum: TestData.VALID_AMPLITUDE_SPECTRUM,
@@ -23,7 +23,7 @@ describe("mfcc", () => {
 
     expect(expectedValues.length).toEqual(en.length);
 
-    for (var index in en) {
+    for (const index in en) {
       expect(Math.abs(en[index] - expectedValues[index])).toBeLessThanOrEqual(
         1e-15
       );
@@ -33,7 +33,7 @@ describe("mfcc", () => {
   });
 
   test("should return only 3 correct mfcc values given a valid signal", (done) => {
-    var en = mfcc({
+    const en = mfcc({
       sampleRate: 44100,
       bufferSize: 512,
       ampSpectrum: TestData.VALID_AMPLITUDE_SPECTRUM,
@@ -47,7 +47,7 @@ describe("mfcc", () => {
 
     expect(expectedValues.length).toEqual(en.length);
 
-    for (var index in en) {
+    for (const index in en) {
       expect(Math.abs(en[index] - expectedValues[index])).toBeLessThanOrEqual(
         1e-15
       );
@@ -57,7 +57,7 @@ describe("mfcc", () => {
   });
 
   test("should return only 40 correct mfcc values given a valid signal", (done) => {
-    var en = mfcc({
+    const en = mfcc({
       sampleRate: 44100,
       bufferSize: 512,
       ampSpectrum: TestData.VALID_AMPLITUDE_SPECTRUM,
@@ -84,7 +84,7 @@ describe("mfcc", () => {
 
     expect(expectedValues.length).toEqual(en.length);
 
-    for (var index in en) {
+    for (const index in en) {
       expect(Math.abs(en[index] - expectedValues[index])).toBeLessThanOrEqual(
         1e-15
       );
@@ -95,23 +95,26 @@ describe("mfcc", () => {
 
   test("should throw an error when passed an empty object", (done) => {
     try {
-      var en = mfcc({});
+      const en = mfcc({});
+      en;
     } catch (e) {
       done();
     }
   });
 
   test("should throw an error when not passed anything", (done) => {
     try {
-      var en = mfcc();
+      const en = mfcc();
+      en;
     } catch (e) {
       done();
     }
   });
 
   test("should throw an error when passed something invalid", (done) => {
     try {
-      var en = mfcc({ signal: "not a signal" });
+      const en = mfcc({ signal: "not a signal" });
+      en;
     } catch (e) {
       done();
     }

__tests__/extractors/perceptualSharpness.ts

@@ -1,11 +1,11 @@
 import TestData from "../TestData";
 
 // Setup
-var percSharp = require("../../dist/node/extractors/perceptualSharpness");
+import percSharp from "../../dist/node/extractors/perceptualSharpness";
 
 describe("percSharp", () => {
   test("should return percSharp value given a valid signal", (done) => {
-    var en = percSharp({
+    const en = percSharp({
       signal: TestData.VALID_SIGNAL,
       ampSpectrum: TestData.VALID_AMPLITUDE_SPECTRUM,
       barkScale: TestData.VALID_BARK_SCALE,
@@ -18,23 +18,26 @@ describe("percSharp", () => {
 
   test("should throw an error when passed an empty object", (done) => {
     try {
-      var en = percSharp({});
+      const en = percSharp({});
+      en;
     } catch (e) {
       done();
     }
   });
 
   test("should throw an error when not passed anything", (done) => {
     try {
-      var en = percSharp();
+      const en = percSharp();
+      en;
     } catch (e) {
       done();
     }
   });
 
   test("should throw an error when passed something invalid", (done) => {
     try {
-      var en = percSharp({ signal: "not a signal" });
+      const en = percSharp({ signal: "not a signal" });
+      en;
     } catch (e) {
       done();
     }