Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate "extractors" export #84

Closed
wants to merge 1 commit into from
Closed

Conversation

jakubfiala
Copy link
Collaborator

This is a small change which opens up access to the internal extractor functions for processing arbitrary Float32 data.

Useful because:

  • enables offline AFE
  • enables FE on non-audio data

@hughrawlinson
Copy link
Member

Just a quick note, offline AFE was already possible with OfflineAudioContext or requiring non-main files from the package, but this makes it really convenient :) Thanks! 👍

@hughrawlinson
Copy link
Member

Actually, maybe consider adding a test so that in the future we know immediately if for any reason this breaks?

@jakubfiala
Copy link
Collaborator Author

Indeed it was, my bad 😊 good point, might add the test later

@hughrawlinson
Copy link
Member

Sorry to be pedantic about it, and I realize that we're not comprehensively tested as it is (when I realistically have time to do something about it I'll investigate metrics for determining testedness and work on improving those), but I think it's probably for the best to only add this once there are tests for it so that we don't slip further back on our testedness. Of course, @jakubfiala and @nevosegal should feel free to overrule me, three person open source core teams are perfect for that kind of governing 😄

I'm happy to write the tests myself this week assuming that you don't mind waiting a few days for this to get merged to master and published to bower and npm?

@jakubfiala jakubfiala mentioned this pull request Oct 13, 2015
@hughrawlinson
Copy link
Member

@jakubfiala is this still relevant after #95?

@hughrawlinson
Copy link
Member

Everything done in this was done in v3.0.0, closing.

@hughrawlinson hughrawlinson deleted the separate-extractors-export branch February 2, 2016 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants