feat: add numberOfBarkBands for loudness feature #971
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
numberOfBarkBands
for theloudness
feature customizable instead of being hard-coded to24
.I followed the example set by
numberOfMFCCCoefficients
.I also had to add a
.prettierrc
so my vscode wouldn't apply global prettier settings. I believe it's a best practice to always include these settings locally per-repo so no matter who's editing the project, they'll all have consistent styling.Cheers 馃挭 馃槂