SVGArcApproximator::approximate() doesn't work properly

[captain-igloo]

I haven't delved too deeply into the maths but the results returned are sometimes incorrect. For example:

$approx = new SVGArcApproximator();
$result = $approx->approximate([10, 10], [20, 10], true, false, 10, 10, 0);

The large arc flag is true but it returns a small arc. I have compared your code with a couple of other implementations. Have a look at this line and line 155. $angleDelta should be adjusted, not $angleStart.
Also vectorAngle() returns a positive number so line 155 is never executed (?)
And is fmod() at line 146 needed ?

[captain-igloo]

duplicate