Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SVGNodeContainer methods should be chainable #9

Closed
meyfa opened this issue Nov 2, 2016 · 0 comments
Closed

SVGNodeContainer methods should be chainable #9

meyfa opened this issue Nov 2, 2016 · 0 comments
Labels
enhancement Improvement to an existing feature

Comments

@meyfa
Copy link
Owner

meyfa commented Nov 2, 2016

To make constructing/editing larger node tree parts easier, SVGNodeContainer::addChild() and SVGNodeContainer::removeChild() should return the node container instance they were called on. This would allow for method chaining exactly like the other node methods already offer.

The return values, which are rarely (if ever) used anyway, could rather easily be replaced with some code on the client's side (a simple for loop over all children, checking whether the subject is among them, would suffice).

@meyfa meyfa added the enhancement Improvement to an existing feature label Nov 2, 2016
@meyfa meyfa closed this as completed in 98aebf0 Nov 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement to an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant