fix: Use String.prototype.slice() instead of deprecated .substr() (…

…#90) * fix: Use `String.prototype.slice()` instead of deprecated `.substr()` * test: Improve string escape test for control characters
meyfa · Sep 17, 2023 · fc128db · fc128db
1 parent 6a59c93
commit fc128db
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/index.ts b/src/index.ts
@@ -66,7 +66,7 @@ function stringifyString (string: string): string {
   // eslint-disable-next-line no-control-regex
   return '"' + string.replace(/[\\"\u0000-\u001F\u2028\u2029]/g, (m) => {
     if (escMap[m] !== undefined) return escMap[m]
-    return '\\u' + (m.charCodeAt(0) + 0x10000).toString(16).substr(1)
+    return '\\u' + (m.charCodeAt(0) + 0x10000).toString(16).slice(1)
   }) + '"'
 }
 

diff --git a/test/index.test.ts b/test/index.test.ts
@@ -119,8 +119,8 @@ describe('index.js', function () {
     it('should escape serialized strings', function () {
       const result: string = index(function (a: string, b: string) {
         return a + ' ' + b
-      }, 'foo"bar\\"\n', 'baz')
-      if (!result.includes(')("foo\\"bar\\\\\\"\\n", "baz")')) {
+      }, 'foo"bar\\"\n-\u0000\u2028\u2029\u0007', 'baz')
+      if (!result.includes(')("foo\\"bar\\\\\\"\\n-\\u0000\\u2028\\u2029\\u0007", "baz")')) {
         throw new Error('incorrect serialization: ' + result)
       }
     })