Skip to content

Commit

Permalink
fix: optimising a potential memory leak
Browse files Browse the repository at this point in the history
  • Loading branch information
meza committed Aug 19, 2023
1 parent 4383270 commit cce8310
Showing 1 changed file with 10 additions and 11 deletions.
21 changes: 10 additions & 11 deletions src/client/java/gg/meza/analytics/Analytics.java
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
import net.minecraft.client.MinecraftClient;
import org.apache.commons.codec.digest.DigestUtils;

import java.util.HashMap;
import java.util.Map;

public class Analytics {
private static final String POSTHOG_API_KEY = "POSTHOG_API_KEY_REPL";
Expand All @@ -18,6 +18,7 @@ public class Analytics {
private final String OS_NAME = System.getProperty("os.name");
private final String MC_VERSION = MinecraftClient.getInstance().getGameVersion();
private final String JAVA_VERSION = System.getProperty("java.version");

public Analytics() {
this.posthog = new PostHog.Builder(POSTHOG_API_KEY).host(POSTHOG_HOST).build();
if (SoundsBeGoneClient.config.isAnalyticsEnabled()) {
Expand All @@ -30,16 +31,14 @@ private void sendEvent(String event, String sound) {
return;
}

this.posthog.capture(this.uuid, event, new HashMap<String, Object>() {
{
put("sound", sound);
put("Minecraft Version", MC_VERSION);
put("OS", OS_NAME);
put("Local Time", new java.util.Date().toString());
put("ModVersion", SoundsBeGone.VERSION);
put("Java Version", JAVA_VERSION);
}
});
this.posthog.capture(this.uuid, event, Map.of(
"sound", sound,
"Minecraft Version", MC_VERSION,
"OS", OS_NAME,
"Local Time", new java.util.Date().toString(),
"ModVersion", SoundsBeGone.VERSION,
"Java Version", JAVA_VERSION
));
}

public void mutedSound(String sound) {
Expand Down

0 comments on commit cce8310

Please sign in to comment.