Merge 243fab2 into e50a8b1

app/models/idea.rb

@@ -48,7 +48,7 @@ class Idea < ActiveRecord::Base
   }
 
   def self.limit_per_state(limit:10)
-    ids = values_of(:id, :state).group_by(&:last).values.map { |id_states| id_states.take(limit).map(&:first) }.flatten
+    ids = pluck(:id, :state).group_by(&:last).values.map { |id_states| id_states.take(limit).map(&:first) }.flatten
     where id:ids
   end
 

spec/models/idea_spec.rb

@@ -78,6 +78,25 @@
     end
   end
 
+  describe '.limit_per_state' do
+    before { Idea.delete_all }
+    let(:result) { Idea.limit_per_state }
+
+    it 'returns a relation' do
+      result.should be_a_kind_of(ActiveRecord::Relation)
+    end
+
+    it 'returns nothing when no ideas' do
+      result.should be_empty
+    end
+
+    it 'returns a mapping when ideas present' do
+      2.times { Idea.make!(state: 0) }
+      1.times { Idea.make!(state: 2) }
+      result.to_a.map(&:state).sort.should == [0, 0, 2]
+    end
+  end
+
   describe '(sort orders)' do
     before { Idea.delete_all }