Skip to content
This repository has been archived by the owner on Apr 26, 2022. It is now read-only.

Missing Ability specs on Comments. #201

Merged
merged 3 commits into from Feb 10, 2014
Merged

Missing Ability specs on Comments. #201

merged 3 commits into from Feb 10, 2014

Conversation

zsombor
Copy link
Contributor

@zsombor zsombor commented Feb 10, 2014

@mezis here are your Ability specs on Comments, fixes #200. My previous #108 did not add any new ability constraints having merely reused the existing code that turned out to be untested.

I feel that adding tests on a lower model level is generally preferable to integration or controller specs. Especially when possible :-)

@mezis
Copy link
Owner

mezis commented Feb 10, 2014

👍 and thanks for the reference to Joseph Fourier!

existing code that turned out to be untested

I'm definitely to blame here. Shouldn't have written most of this in such a hurry ^_^

@zsombor
Copy link
Contributor Author

zsombor commented Feb 10, 2014

OOPS I broke the build on Travis. Seems to work fine locally. Will look into this before closing.

@mezis
Copy link
Owner

mezis commented Feb 10, 2014

Ah, the downside of using fixtures. I'll wait for the build to merge.

mezis added a commit that referenced this pull request Feb 10, 2014
Missing Ability specs on Comments.
@mezis mezis merged commit 4ce6097 into mezis:master Feb 10, 2014
@mezis
Copy link
Owner

mezis commented Feb 10, 2014

Thanks @zsombor!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add missing spec for recent comment edition auth
2 participants