Skip to content
This repository has been archived by the owner on Sep 27, 2022. It is now read-only.

Add :offset option to fuzzy find method. #25

Merged
merged 6 commits into from Dec 7, 2013

Conversation

rickbutton
Copy link
Contributor

It is often required to paginate the results of a search, but
fuzzily doesn't support an offset. An offset parameter was added that
is very similar to the limit parameter, and relies on the ActiveRecord
offset facility.

It is often required to paginate the results of a search, but
fuzzily doesn't support an offset. An offset parameter was added that
is very similar to the limit parameter, and relies on the ActiveRecord
offset facility.
@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling e68dfe0 on rickbutton:search-offset into 4bc7dce on mezis:master.

@mezis
Copy link
Owner

mezis commented Dec 6, 2013

Fab, thanks. I'll merge as soon as the Travis build passes, and release an update probably early next week.

@mezis
Copy link
Owner

mezis commented Dec 6, 2013

Ah, it doesn't work with ActiveRecord 2.3 according to Travis. The simplest is probably to add an offset named scope to Fuzzily::Searchable::Rails2ClassMethods. Would you mind?

@mezis
Copy link
Owner

mezis commented Dec 6, 2013

(also, you're welcome to mention yourself at the bottom of the README!)

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 2d2b621 on rickbutton:search-offset into 4bc7dce on mezis:master.

@rickbutton
Copy link
Contributor Author

Ignore that last commit, worked on my box, not on Travis, looking into it

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 1d22e08 on rickbutton:search-offset into 4bc7dce on mezis:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 1d22e08 on rickbutton:search-offset into 4bc7dce on mezis:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 5fb73c1 on rickbutton:search-offset into 4bc7dce on mezis:master.

@rickbutton
Copy link
Contributor Author

@mezis after lots of fiddling, it passed, so looks like the 2.3 bug is fixed.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 48f7529 on rickbutton:search-offset into 4bc7dce on mezis:master.

@mezis
Copy link
Owner

mezis commented Dec 7, 2013

Nice. I'll merge, do a tiny bit of refactoring, and release.
Thanks again for the contribution! 😸

mezis added a commit that referenced this pull request Dec 7, 2013
Add :offset option to fuzzy find method.
@mezis mezis merged commit efefacb into mezis:master Dec 7, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants