This repository has been archived by the owner on Sep 27, 2022. It is now read-only.
Add :offset option to fuzzy find method. #25
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is often required to paginate the results of a search, but fuzzily doesn't support an offset. An offset parameter was added that is very similar to the limit parameter, and relies on the ActiveRecord offset facility.
Fab, thanks. I'll merge as soon as the Travis build passes, and release an update probably early next week. |
Ah, it doesn't work with ActiveRecord 2.3 according to Travis. The simplest is probably to add an |
(also, you're welcome to mention yourself at the bottom of the README!) |
Ignore that last commit, worked on my box, not on Travis, looking into it |
@mezis after lots of fiddling, it passed, so looks like the 2.3 bug is fixed. |
Nice. I'll merge, do a tiny bit of refactoring, and release. |
mezis
added a commit
that referenced
this pull request
Dec 7, 2013
Add :offset option to fuzzy find method.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is often required to paginate the results of a search, but
fuzzily doesn't support an offset. An offset parameter was added that
is very similar to the limit parameter, and relies on the ActiveRecord
offset facility.