Metric configuration retrieval #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There will be methods specific methods for both tree and hotspot MetricConfiguration retrieval from a KalibroConfiguration instance.
Both can be accessed from KalibroConfiguration isntance. There is a bug on MetricConfiguration.metric setter which is not ready to deal with HotspotMetrics yet.
| As a developer | ||
| I want to get all HotspotMetricConfigurations of a given KalibroConfiguration | ||
|
|
||
| @kalibro_configuration_restart @skip |
The proper fix on 87f8a1f reached mainstream.
There is no need for ReadingGroup on Hotspot ones creation. As well, the scenarion description has been improved mentioning that only hotspot are expected.
|
All is fixed. Thanks for the review 👍 |
|
👍 |
diegoamc
added a commit
that referenced
this pull request
Oct 17, 2015
Metric configuration retrieval
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.