Close #112 Remember if item list overlay has been disabled, add config

gradle.properties

@@ -2,5 +2,5 @@ mcversion=1.8.9
 forgeversion=11.15.0.1697
 
 version_major=2
-version_minor=16
-version_patch=2
+version_minor=17
+version_patch=0

src/main/java/mezz/jei/ItemFilter.java

@@ -173,7 +173,7 @@ private boolean isItemStackHiddenByMissingModel(@Nonnull ItemStack itemStack) {
 					return true;
 				}
 			} catch (RuntimeException e) {
-				Log.error("Couldn't get ItemModel for itemStack {}.", itemStack.getClass(), e);
+				Log.error("Couldn't get ItemModel for itemStack.", e);
 				return true;
 			}
 			return false;

src/main/java/mezz/jei/config/Config.java

@@ -21,6 +21,7 @@ public class Config {
 
 	public static LocalizedConfiguration configFile;
 
+	private static boolean overlayEnabled = true;
 	private static boolean cheatItemsEnabled = false;
 	private static boolean editModeEnabled = false;
 	private static boolean debugModeEnabled = false;
@@ -44,6 +45,21 @@ private Config() {
 
 	}
 
+	public static boolean isOverlayEnabled() {
+		return overlayEnabled;
+	}
+
+	public static void toggleOverlayEnabled() {
+		overlayEnabled = !overlayEnabled;
+
+		Property property = configFile.getConfiguration().get(CATEGORY_INTERFACE, "overlayEnabled", overlayEnabled);
+		property.set(overlayEnabled);
+
+		if (configFile.hasChanged()) {
+			configFile.save();
+		}
+	}
+
 	public static boolean isCheatItemsEnabled() {
 		return cheatItemsEnabled;
 	}
@@ -105,6 +121,8 @@ public static boolean syncConfig() {
 		configFile.addCategory(CATEGORY_ADVANCED);
 		configFile.addCategory(CATEGORY_ADDONS);
 
+		overlayEnabled = configFile.getBoolean(CATEGORY_INTERFACE, "overlayEnabled", overlayEnabled);
+
 		cheatItemsEnabled = configFile.getBoolean(CATEGORY_MODE, "cheatItemsEnabled", cheatItemsEnabled);
 		editModeEnabled = configFile.getBoolean(CATEGORY_MODE, "editEnabled", editModeEnabled);
 

src/main/java/mezz/jei/gui/ItemListOverlay.java

@@ -80,7 +80,6 @@ public class ItemListOverlay implements IShowsRecipeFocuses, IMouseHandler, IKey
 	private int screenHeight;
 
 	private boolean open = false;
-	private boolean enabled = true;
 
 	public ItemListOverlay(ItemFilter itemFilter) {
 		this.itemFilter = itemFilter;
@@ -427,10 +426,6 @@ public void close() {
 
 	@Override
 	public boolean isOpen() {
-		return open && enabled;
-	}
-
-	public void toggleEnabled() {
-		enabled = !enabled;
+		return open && Config.isOverlayEnabled();
 	}
 }

src/main/java/mezz/jei/input/InputHandler.java

@@ -212,7 +212,7 @@ private boolean handleKeyDown(int eventKey) {
 
 		if (GuiScreen.isCtrlKeyDown()) {
 			if (eventKey == KeyBindings.toggleOverlay.getKeyCode()) {
-				itemListOverlay.toggleEnabled();
+				Config.toggleOverlayEnabled();
 				return false;
 			} else if (eventKey == Keyboard.KEY_F) {
 				itemListOverlay.setKeyboardFocus(true);

src/main/resources/assets/jei/lang/en_US.lang

@@ -32,6 +32,8 @@ config.jei.mode.editEnabled.comment=Hide and unhide items by clicking them in th
 
 config.jei.interface=Interface
 config.jei.interface.comment=Options relating to the User Interface.
+config.jei.interface.overlayEnabled=Item List Overlay
+config.jei.interface.overlayEnabled.comment=Show the list of items next to open guis.
 config.jei.interface.recipeAnimationsEnabled=Recipe Animations
 config.jei.interface.recipeAnimationsEnabled.comment=Show recipe animations (furnace fire, progress bars, etc)