Fix duplicate items when they are added by a mod at runtime from the API

mezz · Oct 21, 2017 · 4937b44 · 4937b44
1 parent 48c6e11
commit 4937b44
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/src/main/java/mezz/jei/ingredients/IngredientRegistry.java b/src/main/java/mezz/jei/ingredients/IngredientRegistry.java
@@ -165,15 +165,20 @@ public <V> void addIngredientsAtRuntime(Class<V> ingredientClass, List<V> ingred
 		IIngredientHelper<V> ingredientHelper = getIngredientHelper(ingredientClass);
 		//noinspection unchecked
 		Set<V> set = ingredientsMap.computeIfAbsent(ingredientClass, k -> IngredientSet.create(ingredientClass, ingredientHelper));
+		List<V> newIngredients = new ArrayList<>(ingredients.size());
 		for (V ingredient : ingredients) {
-			set.add(ingredient);
+			if (set.add(ingredient)) {
+				newIngredients.add(ingredient);
+			}
 			if (ingredient instanceof ItemStack) {
 				getStackProperties((ItemStack) ingredient);
 			}
 		}
 
-		NonNullList<IIngredientListElement> ingredientListElements = IngredientListElementFactory.createList(this, ingredientClass, ingredients, modIdHelper);
-		ingredientFilter.addIngredients(ingredientListElements);
+		if (!newIngredients.isEmpty()) {
+			NonNullList<IIngredientListElement> ingredientListElements = IngredientListElementFactory.createList(this, ingredientClass, newIngredients, modIdHelper);
+			ingredientFilter.addIngredients(ingredientListElements);
+		}
 	}
 
 	@Override