Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.12.2] [suggestion] Show hidden Items in Recipes #1567

Closed
ToMe25 opened this issue May 1, 2019 · 8 comments
Closed

[1.12.2] [suggestion] Show hidden Items in Recipes #1567

ToMe25 opened this issue May 1, 2019 · 8 comments

Comments

@ToMe25
Copy link

ToMe25 commented May 1, 2019

If someone uses a Item in a Recipe that is in no Creative Tab or hidden JEI displays an empty Slot, i think this shouldn't be the case.

@ToMe25
Copy link
Author

ToMe25 commented May 1, 2019

By the Way Items being in no Creative Tab got rendered in Recipes in 1.10/1.11 so i think maybe it's a Bug that they don't render with JEI 1.12.2.

@mezz
Copy link
Owner

mezz commented May 12, 2019

Thanks for the report!
In most cases, recipes should show hidden items.
If there are a list of items for one slot, some are hidden and some are not, then only the unhidden items are shown. I believe that is the only case where items are hidden in recipes.
Do you have some other bug where an item is not rendering?

@ToMe25
Copy link
Author

ToMe25 commented May 12, 2019

The Main Case i had was with Thermal Foundation.
Thermal Foundation adds some Tools(for example the Wooden Excavator) but don't adds them to a Creative Tab with Default Config and don't adds Recipes for them.
My Mod Armor&ToolUpgrading adds Recipes using that Tools and than the Tools aren't rendered in the Recipe.

I had that too with only Mods from other Persons but i don't know what Mods i used so i can't report that.

@ToMe25
Copy link
Author

ToMe25 commented May 12, 2019

For Example Armor&ToolUpgrading makes you need the Wooden Excavator for the Stone one and in that Recipe there is an empty Slot instead of the Wooden Excavator.
And you need the Stone Excavator for the Copper one(the First visible).

@mezz
Copy link
Owner

mezz commented May 12, 2019

Ok, interestingly this has the same underlying issue as #1575, please take a look at my response there.
I will see if there is something I can do to display those items in recipes better.

@ToMe25
Copy link
Author

ToMe25 commented May 12, 2019

I know i could add the Items to a Creative Tab or enable in the Thermal Foundation Config to add them to a Creative tab but i want it to work with the default Config and it's a Bug even if you can work around it.
I figured that out during testing before reporting.

mezz added a commit that referenced this issue May 12, 2019
@mezz
Copy link
Owner

mezz commented May 12, 2019

I have pushed a "fix" for this where it will at least display something instead of a blank spot.
It is not entirely perfect because if there are multiple subtypes, JEI will just display the first one, but it should resolve this issue.

I tested with your mod and it seems to be displaying things properly.

@mezz mezz closed this as completed May 12, 2019
@ToMe25
Copy link
Author

ToMe25 commented May 12, 2019

ok thanks :)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants