draft PR for supporting ircut get/set and genericizing service call #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm opening to making a change like this. My main concern is covering the edge cases though. There have been quite a few tweaks included here and there to work with different camera behavior and I would want to make sure those are retained. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is working on my hik camera now.
Rather than clone all the existing code for get and put, I've refactored a new method that will make any http call. It can also make a PUT request using XML from a previous GET request and overriding based on keyword args, so very easy to create new PUT calls ( so long as still able to find an ISAPI doc pdf!)
If you like this, don't merge but let me know. I'll add tests, and refactor the existing get/put to use the new call_service