Compatibility fix with is_confidential check in league's oauth2-server library #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r library Signed-off-by: srggroup <adam.balint@srg.hu>
weierophinney
added a commit
that referenced
this pull request
Jun 30, 2020
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
weierophinney
added a commit
that referenced
this pull request
Jun 30, 2020
|
Thanks, @adambalint-srg! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: adambalint-srg adam.balint@srg.hu
Description
The league/oauth2-server library makes an other check in ClientCredentialsGrant. It checks if the client is confidential, and if not, the flow will aborted with 401.
The tests have been failed because of this, so it's fixed in this pull request with some db-structure and test-db content modifications, and with a plus test to check both cases.