Apply PHP 7.4 syntax and typed property #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ocramius
requested changes
Sep 17, 2022
There was a problem hiding this comment.
Wait, loads of failures:
There were 5 errors:
1) MezzioTest\Authentication\OAuth2\Repository\Pdo\AccessTokenRepositoryFactoryTest::testFactory
TypeError: Typed property MezzioTest\Authentication\OAuth2\Repository\Pdo\AccessTokenRepositoryFactoryTest::$container must be an instance of Psr\Container\ContainerInterface, Prophecy\Prophecy\ObjectProphecy used
/github/workspace/test/Repository/Pdo/AccessTokenRepositoryFactoryTest.php:22
phpvfscomposer:///github/workspace/vendor/phpunit/phpunit/phpunit:97
2) MezzioTest\Authentication\OAuth2\Repository\Pdo\AuthCodeRepositoryFactoryTest::testFactory
TypeError: Typed property MezzioTest\Authentication\OAuth2\Repository\Pdo\AuthCodeRepositoryFactoryTest::$container must be an instance of Psr\Container\ContainerInterface, Prophecy\Prophecy\ObjectProphecy used
/github/workspace/test/Repository/Pdo/AuthCodeRepositoryFactoryTest.php:22
phpvfscomposer:///github/workspace/vendor/phpunit/phpunit/phpunit:97
3) MezzioTest\Authentication\OAuth2\Repository\Pdo\ClientRepositoryFactoryTest::testFactory
TypeError: Typed property MezzioTest\Authentication\OAuth2\Repository\Pdo\ClientRepositoryFactoryTest::$container must be an instance of Psr\Container\ContainerInterface, Prophecy\Prophecy\ObjectProphecy used
/github/workspace/test/Repository/Pdo/ClientRepositoryFactoryTest.php:22
phpvfscomposer:///github/workspace/vendor/phpunit/phpunit/phpunit:97
4) MezzioTest\Authentication\OAuth2\Repository\Pdo\RefreshTokenRepositoryFactoryTest::testFactory
TypeError: Typed property MezzioTest\Authentication\OAuth2\Repository\Pdo\RefreshTokenRepositoryFactoryTest::$container must be an instance of Psr\Container\ContainerInterface, Prophecy\Prophecy\ObjectProphecy used
/github/workspace/test/Repository/Pdo/RefreshTokenRepositoryFactoryTest.php:22
phpvfscomposer:///github/workspace/vendor/phpunit/phpunit/phpunit:97
5) MezzioTest\Authentication\OAuth2\Repository\Pdo\ScopeRepositoryFactoryTest::testFactory
TypeError: Typed property MezzioTest\Authentication\OAuth2\Repository\Pdo\ScopeRepositoryFactoryTest::$container must be an instance of Psr\Container\ContainerInterface, Prophecy\Prophecy\ObjectProphecy used
/github/workspace/test/Repository/Pdo/ScopeRepositoryFactoryTest.php:22
phpvfscomposer:///github/workspace/vendor/phpunit/phpunit/phpunit:97
I think we may need to remove prophecy as part of our refactoring work
samsonasik
force-pushed
the
apply-php74
branch
2 times, most recently
from
e9c198b
to
346fc71
Compare
|
@Ocramius it should be fixed now. |
samsonasik
force-pushed
the
apply-php74
branch
2 times, most recently
from
4be9da1
to
8d4125b
Compare
|
Nope 🤔 |
Signed-off-by: Abdul Malik Ikhsan <samsonasik@gmail.com>
samsonasik
force-pushed
the
apply-php74
branch
from
8d4125b
to
c06922c
Compare
|
Let's try again |
|
@Ocramius All green 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Abdul Malik Ikhsan samsonasik@gmail.com
Description
Since composer.json require php 7.4, php 7.4 syntax can be applied with typed properties.
final class, typed properties for protected is allowed if no inherit of parent or used by its final class parent.final class, typed properties for protected can be changed toprivateif not used in parent or exists in parent class.