Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Psalm integration #14

Merged
merged 5 commits into from
Oct 13, 2021
Merged

Psalm integration #14

merged 5 commits into from
Oct 13, 2021

Conversation

jslmorrison
Copy link
Contributor

Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC no
QA yes

Description

Psalm static analysis integration

Signed-off-by: John Morrison <jslmorrison@gmail.com>
Signed-off-by: John Morrison <jslmorrison@gmail.com>
Also adds the generated psalm-baseline.xml file.

Signed-off-by: John Morrison <jslmorrison@gmail.com>
Signed-off-by: John Morrison <jslmorrison@gmail.com>
@froschdesign froschdesign linked an issue Jun 26, 2021 that may be closed by this pull request
8 tasks
@froschdesign froschdesign added the Enhancement New feature or request label Jun 26, 2021
@froschdesign
Copy link
Member

@jslmorrison
At the moment the Pslam baseline file contains many errors, do you see a chance to fix some of them?

Thank you for your help here and with other packages! 👍

- changes `totallyTyped=true` to `errorLevel=1` which is equivalent
- adds `psalm.xml` to `.gitignore` while renaming it to `psalm.xml.dist`
- adds `psalm.xml.dist` to `.gitattributes` so we do not ship this component with its psalm config
- remove `.coveralls.yml` as we do not provide anything to coveralls with the new CI pipeline

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing boesing added this to To do in Psalm via automation Oct 13, 2021
@boesing boesing added this to the 1.2.0 milestone Oct 13, 2021
@boesing boesing merged commit 53fe9e0 into mezzio:1.2.x Oct 13, 2021
Psalm automation moved this from To do to Done Oct 13, 2021
@boesing
Copy link
Member

boesing commented Oct 13, 2021

Thanks, @jslmorrison !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
Psalm
  
Done
Development

Successfully merging this pull request may close these issues.

Psalm integration
3 participants