Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: ensure non-empty string default for allowedMaxAge configuration #13

Merged
merged 3 commits into from
Oct 31, 2020
Merged

bugfix: ensure non-empty string default for allowedMaxAge configuration #13

merged 3 commits into from
Oct 31, 2020

Conversation

boesing
Copy link
Member

@boesing boesing commented Oct 6, 2020

Q A
Bugfix yes

Description

This PR should fix #12 as there was no default value for the allowed_max_age configuration.

@boesing
Add failing unit test for mezzio#12
81e29d5 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing
Added default value for AbstractConfiguration::allowedMaxAge
439f11e 
Fixes mezzio#12

Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing boesing added Bug Something isn't working hacktoberfest-accepted Issues/Pull-Requests which can be fixed during Hacktoberfest: https://hacktoberfest.digitalocean.com labels Oct 6, 2020
@boesing boesing added this to the 1.0.2 milestone Oct 6, 2020
@boesing boesing linked an issue Oct 6, 2020 that may be closed by this pull request
Access-Control-Max-Age without value #12
Closed
froschdesign
froschdesign approved these changes Oct 27, 2020
View reviewed changes
Copy link
Member

@froschdesign froschdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Value -1 looks good. 👍

@boesing
Add CHANGELOG entry
10e16e7 
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
@boesing boesing merged commit b8d601d into mezzio:1.0.x Oct 31, 2020
@boesing boesing deleted the bugfix/issue-12 branch October 31, 2020 11:21
@boesing boesing mentioned this pull request Oct 31, 2020
Closed
@github-actions github-actions bot mentioned this pull request Oct 31, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@froschdesign froschdesign froschdesign approved these changes

Assignees
No one assigned
Labels
Bug Something isn't working hacktoberfest-accepted Issues/Pull-Requests which can be fixed during Hacktoberfest: https://hacktoberfest.digitalocean.com
Projects
None yet
Milestone
1.0.2
Development

Successfully merging this pull request may close these issues.

Access-Control-Max-Age without value
2 participants
@boesing @froschdesign