Fix RiskyTruthyFalsyComparison issues

Signed-off-by: George Steel <george@net-glue.co.uk>
mezzio · Feb 8, 2024 · dc75d28 · dc75d28
1 parent abb71f7
commit dc75d28
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/ProblemDetailsResponseFactory.php b/src/ProblemDetailsResponseFactory.php
@@ -220,7 +220,7 @@ public function __construct(
         }
         // Ensures type safety of the composed factory
         $this->responseFactory = $responseFactory;
-        if (! $jsonFlags) {
+        if ($jsonFlags === null) {
             $jsonFlags = JSON_UNESCAPED_SLASHES
                 | JSON_UNESCAPED_UNICODE
                 | JSON_PRESERVE_ZERO_FRACTION

diff --git a/test/ProblemDetailsResponseFactoryTest.php b/test/ProblemDetailsResponseFactoryTest.php
@@ -144,7 +144,7 @@ public function testCreateResponseRemovesInvalidCharactersFromXmlKeys(string $he
             ],
         ];
 
-        if (stripos($expectedType, 'xml')) {
+        if (stripos($expectedType, 'xml') !== false) {
             $expectedKeyNames = [
                 'A_-',
                 '_A-',