Add PHP 8 Support #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added `~8.0.0` to the PHP constraint - Bumped minimum supported PHPUnit version to 9.3 - Added PHP 8 jobs to Travis configuration - Updated unit tests to work under PHPUnit 9.3 - Replaced Prophecy mocking with PHPUnit native mocking Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
- Updates to laminas-coding-standard 2.1 - Applies rules to codebase Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
|
Unclear why phpcs is failing to find the laminas-coding-standard. I can run the exact same commands as Travis locally, using PHP 7.4.11, and everything works fine. I'll see if it resolves with the next patch I do for Psalm support. |
weierophinney
added a commit
that referenced
this pull request
Oct 9, 2020
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
~8.0.0to the PHP constraintFixes #5