-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extra info to home-page json response #20
Add extra info to home-page json response #20
Conversation
Hello @michalbundyra , In the new test case I had to skip the auryn test. I believe I found a bug in the psr auryn wrapper for zend configurations, but I haven't still looked deeply into it. https://github.com/northwoods/container/blob/master/src/Zend/Config.php#L73
'invokables' => [
AuraRouter::class => AuraRouter::class,
], kind regards, |
@pine3ree it needs rebase against latest develop. |
Signed-off-by: pine3ree <pine3ree@gmail.com>
Signed-off-by: pine3ree <pine3ree@gmail.com>
Signed-off-by: pine3ree <pine3ree@gmail.com>
Signed-off-by: pine3ree <pine3ree@gmail.com>
Signed-off-by: pine3ree <pine3ree@gmail.com>
e08155c
to
176e9db
Compare
@samsonasik , right! thanks! |
private $expectedRouterAttributes = [ | ||
AuraRouter::class => [ | ||
'routerName' => 'Aura.Router', | ||
'routerDocs' => 'http://auraphp.com/packages/2.x/Router.html', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use v3 actually, see https://github.com/mezzio/mezzio-aurarouter/blob/a22e92f0e79445229e57a612eb5acf2e841d2cb6/composer.json#L37
probably routerDocs link can be changed to http://auraphp.com/packages/3.x/Router/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @samsonasik, I have to wait for HomePageHandler-updating PRs to be pulled-in (for aura-di v4 as well), otherwise the response-inspecting tests would fail.
Pinging @michalbundyra as well: maybe in a future version we could add a support class (or a HomePageHandler public constant) defining name and docs based on the container/router/renderer FQCN, so that we have one "place" to make those changed. This would simplify updating the test cases a lot. kind regards.
@pine3ree Could you please update the PR description to detail what the returned payload looks like (so people coming to the issue from the changelog can see at a glance what was changed, without having to look through the patches)? Thanks! |
@weierophinney done! kind regards. |
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Description
Just add container and router info to home-page-example json response for renderer/template-less installs, to partially match the info provided by the html-response.
ref: #3 (added test case as suggested by ocramius)
Specifically the json-response payload is changed from:
to the following more complete version: