Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to GHA CI workflow #42

Merged
merged 7 commits into from
May 10, 2021
Merged

Switch to GHA CI workflow #42

merged 7 commits into from
May 10, 2021

Conversation

internalsystemerror
Copy link
Member

Switch from Travis CI to use GitHub Actions according to: https://gist.github.com/weierophinney/b003e50c3c2667d08076caf31ebd36a4.

This closes #41

@internalsystemerror internalsystemerror changed the title Switch to GHA CI workflow WIP: Switch to GHA CI workflow Apr 24, 2021
Gary Lockett added 3 commits April 24, 2021 15:53
Signed-off-by: Gary Lockett <gary@creativecow.uk>
Signed-off-by: Gary Lockett <gary@creativecow.uk>
Signed-off-by: Gary Lockett <gary@creativecow.uk>
@internalsystemerror
Copy link
Member Author

internalsystemerror commented Apr 24, 2021

I'm getting different results locally compared to here ... I actually pass CS checks locally since phpcs.xml is used whereas here it seems to be using phpcs.xml.dist instead (just a hypothesis) (edit: fixed). And I'm also failing a lot more tests locally, feel free to take over this PR as needed otherwise I'll check back on this later.

@froschdesign froschdesign added the Enhancement New feature or request label Apr 24, 2021
@froschdesign froschdesign added this to In progress in Switch from Travis-Ci to GitHub Actions via automation Apr 24, 2021
Signed-off-by: Gary Lockett <gary@creativecow.uk>
@internalsystemerror internalsystemerror changed the title WIP: Switch to GHA CI workflow Switch to GHA CI workflow May 10, 2021
@internalsystemerror
Copy link
Member Author

I believe this is now ready for review

@weierophinney weierophinney added this to the 3.8.0 milestone May 10, 2021
Due to chubbyphp/container, as lockfile uses v2, which requires 7.4+.

Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
- Removes errantly provided phpcs.xml, which duplicated phpcs.xml.dist, but poorly.
- Fixes errors discovered during phpcs run.

Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
- config file gets updated as we are not using `--no-scripts` during composer install
- routes file is copied from source during composer install

Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
@weierophinney weierophinney merged commit dfd8aa2 into mezzio:3.8.x May 10, 2021
Switch from Travis-Ci to GitHub Actions automation moved this from In progress to Done May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Switch to GHA CI workflow
4 participants