Fix/dependencies for php 8.1.x #60
Conversation
Removed packages:
- laminas/laminas-auradi-config
- mezzio/mezzio-aurarouter
- northwoods/container
Updated packages:
- jsoumelidis/zend-sf-di-config from ^0.4 to ^0.5
- mezzio/mezzio-tooling from ^1.4.0 to ^2.0
Also removed all usages and mentions of auradi aurarouter and auryn
Signed-off-by: Lukas Langen <lukas@langen.dev>
Signed-off-by: Lukas Langen <lukas@langen.dev>
There was a problem hiding this comment.
LGTM.
@weierophinney @boesing can you check? I think having less integration work here is a good idea.
|
I think removing Aura is a good call, since that project hasn't been updated in some time and doesn't appear that it will be. I'm migrating clients to Mezzio away from Aura, because it's not actively supported. |
|
CS fixes are still running on 7.3: perhaps we just need to drop support for that? |
There was a problem hiding this comment.
I agree with @Ocramius — bump the minimum supported PHP version to 7.4. From there, also do the following:
- Bump laminas-coding-standard to
^2.3(and fix any issues raised). - Bump PHPUnit to
^9.5.5. - Check other dependencies to determine which version first offers PHP 8.1 support, and bump to that when possible.
- Audit the cs-check and cs-fix scripts; is the
DealerDirect....Plugin::runline really required for these anymore?
Before we release, I'd also like to see a separate PR that replaces phpstan with psalm, so that this package is consistent with our other packages.
Signed-off-by: Lukas Langen <lukas@langen.dev>
Signed-off-by: Lukas Langen <lukas@langen.dev>
Signed-off-by: Lukas Langen <lukas@langen.dev>
Signed-off-by: Lukas Langen <lukas@langen.dev>
Signed-off-by: Lukas Langen <lukas@langen.dev>
Signed-off-by: Lukas Langen <lukas@langen.dev>
Signed-off-by: Lukas Langen <lukas@langen.dev>
Signed-off-by: Lukas Langen <lukas@langen.dev>
Signed-off-by: Lukas Langen <lukas@langen.dev>
Signed-off-by: Lukas Langen <lukas@langen.dev>
|
Okay. I've added the specifically requested new version constraints and checked all version constraints for Also on the way I removed As for the cs-fix stuff: I don't have the time right now to go more deeply into this, but it seems, that this line is necessary to install all coding standards found in the vendor directory. It seems especially necessary for CI (at least after my understanding of the package's documentation, see here If it still should be removed, please just tell me and I'll do it as soon, as I have time for it. |
What's odd is we literally don't have that in any other package we ship, and CI works just fine. :) I have time today, so I'll see if I can push that change and fixes for the failing unit tests on 7.4 with lowest deps. |
As of Composer 2.2, we need to add an "allow-plugins" configuration directive with a list of plugins we allow (see https://getcomposer.org/doc/06-config.md#allow-plugins). Additionally, the installation was not originally performed with PHP 7.4, which meant that when running `--prefer-lowest`, we would run into errors. Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
These are not needed in any of our packages, and I've not needed them in any sites with which I use laminas-coding-standard or phpcs. If CI fails, I'll revert. Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
Description
See #59