Allow access to dispatcher and Swoole HTTP Server instances in extending classes #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…classes To allow changing how events are attached, particularly when using third-party extensions that need to attach directly to the server and decorate the main functionality (e.g., timers), the swoole instance should be exposed. Exposing the dispatcher also allows extending the various internal methods in a way that allows their individual logic to be wrapped. Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
weierophinney
added a commit
that referenced
this pull request
Dec 2, 2020
Signed-off-by: Matthew Weier O'Phinney <matthew@weierophinney.net>
weierophinney
deleted the
feature/44-allow-access-to-swoole-server-instance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow changing how events are attached, particularly when using third-party extensions that need to attach directly to the server and decorate the main functionality (e.g., timers), the swoole instance should be exposed. Exposing the dispatcher also allows extending the various internal methods in a way that allows their individual logic to be wrapped.
Fixes #44