Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce mockery/mockery and Prophecy mocking dependency usages #37

Merged
merged 2 commits into from
Nov 25, 2022

Conversation

Ocramius
Copy link
Member

Q A
Documentation no
Bugfix no
BC Break no
New Feature no
RFC yes
QA yes

These are my changes from #36, extracted here.

I did a partial removal of mockery/mockery and prophecy/prophecy, which are both not really necessary in these context.

Further work needs to be done to improve the code structure of the test suite, but this PR at least contains the work done so far.

@Ocramius Ocramius added Enhancement New feature or request dependencies Pull requests that update a dependency file labels Nov 25, 2022
@Ocramius Ocramius added this to the 2.7.0 milestone Nov 25, 2022
Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Ocramius Ocramius self-assigned this Nov 25, 2022
@Ocramius Ocramius merged commit b16fae7 into 2.7.x Nov 25, 2022
@Ocramius Ocramius deleted the feature/reduce-mockery-usage branch November 25, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants