Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Application with RequestHandlerRunnerInterface instead of RequestHandlerRunner, alias RequestHandlerRunner as RequestHandlerRunnerInterface #110

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Build Application with RequestHandlerRunnerInterface instead of RequestHandlerRunner, alias RequestHandlerRunner as RequestHandlerRunnerInterface #110

merged 1 commit into from
Apr 20, 2022

Conversation

byan
Copy link
Contributor

@byan byan commented Feb 20, 2022

Q A
BC Break no
New Feature yes

Description

Using interface-based dependence allows us to swtich the other implementations more easily.

@Ocramius Ocramius self-assigned this Feb 20, 2022
@Ocramius Ocramius added the Enhancement New feature or request label Feb 20, 2022
@Ocramius Ocramius added this to the 3.11.0 milestone Feb 20, 2022
@Ocramius
Copy link
Member

This can go in 3.11.x, but I see that the branch wasn't created 🤔

Ocramius
Ocramius approved these changes Feb 20, 2022
View reviewed changes
Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @byan! LGTM!

@boesing
Copy link
Member

boesing commented Apr 20, 2022

This can go to 3.11.x indeed, but we should change this from aliases to factories in 4.x since RequestHandlerRunner should not be requestable as a service from the container.

Since delegators only work on services, this would be a BC break for sure and therefore I'd like to keep this in mind and thus dropping it here. Creating a new issue for 4.x from this comment to keep track.

@boesing boesing mentioned this pull request Apr 20, 2022
Open
@boesing boesing changed the base branch from 4.0.x to 3.11.x April 20, 2022 10:11
@boesing boesing mentioned this pull request Apr 20, 2022
Merged
@byan @Ocramius
Build Application with RequestHandlerRunnerInterface instead of Reque…
4adcdd7 
…stHandlerRunner

Signed-off-by: Ben Yan <i@yanbin.org>
@Ocramius
Copy link
Member

Rebased, thanks @byan!

@Ocramius Ocramius changed the title Build Application with RequestHandlerRunnerInterface instead of RequestHandlerRunner Build Application with RequestHandlerRunnerInterface instead of RequestHandlerRunner, alias RequestHandlerRunner as RequestHandlerRunnerInterface Apr 20, 2022
@Ocramius Ocramius merged commit 9d12898 into mezzio:3.11.x Apr 20, 2022
@github-actions github-actions bot mentioned this pull request Jun 29, 2022
Merged
@byan byan deleted the runner-interface branch June 30, 2022 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ocramius Ocramius Ocramius approved these changes

Assignees

@Ocramius Ocramius

Labels
Enhancement New feature or request
Projects
None yet
Milestone
3.11.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@byan @Ocramius @boesing