Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP 8.0 compatiblity and dependency upgrades. #60

Merged
merged 17 commits into from
Jan 24, 2021
Merged

PHP 8.0 compatiblity and dependency upgrades. #60

merged 17 commits into from
Jan 24, 2021

Conversation

jensdenies
Copy link
Contributor

Q A
Documentation no
Bugfix no
BC Break no
New Feature yes
RFC no
QA no

Description

This pull requests aims to make Mezzio PHP 8.0 compatible. I've bumped the dependencies to the lowest version that supports PHP 7.3 up until 8.0.

Signed-off-by: Jens de Nies <j.de.nies@protonmail.com>
Signed-off-by: Jens de Nies <j.de.nies@protonmail.com>
Signed-off-by: Jens de Nies <j.de.nies@protonmail.com>
Signed-off-by: Jens de Nies <j.de.nies@protonmail.com>
Signed-off-by: Jens de Nies <j.de.nies@protonmail.com>
Signed-off-by: Jens de Nies <j.de.nies@protonmail.com>
Signed-off-by: Jens de Nies <j.de.nies@protonmail.com>
Signed-off-by: Jens de Nies <j.de.nies@protonmail.com>
Signed-off-by: Jens de Nies <j.de.nies@protonmail.com>
Signed-off-by: Jens de Nies <j.de.nies@protonmail.com>
Signed-off-by: Jens de Nies <j.de.nies@protonmail.com>
Signed-off-by: Jens de Nies <j.de.nies@protonmail.com>
Signed-off-by: Jens de Nies <j.de.nies@protonmail.com>
Signed-off-by: Jens de Nies <j.de.nies@protonmail.com>
Signed-off-by: Jens de Nies <j.de.nies@protonmail.com>
@jensdenies jensdenies marked this pull request as ready for review January 13, 2021 23:11
@jensdenies
Copy link
Contributor Author

jensdenies commented Jan 13, 2021

@lcobucci Tests seem to pass. 😃

mezzio/mezzio-aurarouter and mezzio/mezzio-template do not seem to have a PHP 8 compatible release yet (there are open PRs for that), that's why I had to ignore platform requirements in Travis.

@jensdenies
Copy link
Contributor Author

jensdenies commented Jan 19, 2021

Hi @boesing, @lcobucci, would you prefer holding this off until the PHP 8 upgrades for mezzio-template and mezzio-aurarouter are completed? 😀

@acelaya
Copy link
Contributor

acelaya commented Jan 23, 2021

The one for mezzio-template has just been merged by @samsonasik and he released v2.1, so only aurarouter one is missing now.

@acelaya acelaya mentioned this pull request Jan 23, 2021
28 tasks
Signed-off-by: Jens de Nies <j.de.nies@protonmail.com>
@jensdenies
Copy link
Contributor Author

@acelaya I've updated the dependency, thanks for notifying me! 👍

@lcobucci
Copy link
Member

lcobucci commented Jan 24, 2021

Sorry @jensdenies I had a crazy busy week. It looks good to me and I don't think we must wait for the other packages. The only thing we're missing here is the cleanup of the compatibility layer on whoops (the code and the phpstan config have some stuff for whoops v1).

@jensdenies
Copy link
Contributor Author

@lcobucci No worries! I'll take a look! 😀

Signed-off-by: Jens de Nies <j.de.nies@protonmail.com>
@jensdenies
Copy link
Contributor Author

@lcobucci I've removed the obsolete code. 👍

@Ocramius
Copy link
Member

Deferred removal of --ignore-platform-reqs to #62

Copy link
Member

@Ocramius Ocramius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@Ocramius Ocramius merged commit 38baf11 into mezzio:3.3.x Jan 24, 2021
@jensdenies jensdenies deleted the feature/php8 branch January 24, 2021 21:12
@jensdenies
Copy link
Contributor Author

Thanks @Ocramius and @lcobucci!

@Ocramius Ocramius mentioned this pull request Jan 24, 2021
6 tasks
@jensdenies
Copy link
Contributor Author

@Ocramius @lcobucci I just realized, the dependency upgrade wasn't actually necessary, right? Because Composer would've pulled the correct version anyway if there was a compatible PHP 8 release.

@lcobucci
Copy link
Member

lcobucci commented Feb 1, 2021

Sure, but it's definitely good to keep them updated (IMHO)

@jensdenies
Copy link
Contributor Author

@lcobucci Cool, thought so too! It just occurred to me while I was updating another package, haha.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants