-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PHP 8.0 compatiblity and dependency upgrades. #60
Conversation
Signed-off-by: Jens de Nies <j.de.nies@protonmail.com>
Signed-off-by: Jens de Nies <j.de.nies@protonmail.com>
Signed-off-by: Jens de Nies <j.de.nies@protonmail.com>
Signed-off-by: Jens de Nies <j.de.nies@protonmail.com>
Signed-off-by: Jens de Nies <j.de.nies@protonmail.com>
Signed-off-by: Jens de Nies <j.de.nies@protonmail.com>
Signed-off-by: Jens de Nies <j.de.nies@protonmail.com>
Signed-off-by: Jens de Nies <j.de.nies@protonmail.com>
Signed-off-by: Jens de Nies <j.de.nies@protonmail.com>
Signed-off-by: Jens de Nies <j.de.nies@protonmail.com>
Signed-off-by: Jens de Nies <j.de.nies@protonmail.com>
Signed-off-by: Jens de Nies <j.de.nies@protonmail.com>
Signed-off-by: Jens de Nies <j.de.nies@protonmail.com>
Signed-off-by: Jens de Nies <j.de.nies@protonmail.com>
Signed-off-by: Jens de Nies <j.de.nies@protonmail.com>
@lcobucci Tests seem to pass. 😃
|
The one for mezzio-template has just been merged by @samsonasik and he released v2.1, so only aurarouter one is missing now. |
Signed-off-by: Jens de Nies <j.de.nies@protonmail.com>
@acelaya I've updated the dependency, thanks for notifying me! 👍 |
Sorry @jensdenies I had a crazy busy week. It looks good to me and I don't think we must wait for the other packages. The only thing we're missing here is the cleanup of the compatibility layer on whoops (the code and the phpstan config have some stuff for whoops v1). |
@lcobucci No worries! I'll take a look! 😀 |
Signed-off-by: Jens de Nies <j.de.nies@protonmail.com>
@lcobucci I've removed the obsolete code. 👍 |
Deferred removal of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚢
Sure, but it's definitely good to keep them updated (IMHO) |
@lcobucci Cool, thought so too! It just occurred to me while I was updating another package, haha. |
Description
This pull requests aims to make Mezzio PHP 8.0 compatible. I've bumped the dependencies to the lowest version that supports PHP 7.3 up until 8.0.