Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR - ios example #18

Merged
merged 6 commits into from
Aug 20, 2019
Merged

PR - ios example #18

merged 6 commits into from
Aug 20, 2019

Conversation

adelmojunnior
Copy link
Collaborator

No description provided.

@adelmojunnior adelmojunnior changed the title Mr ios example PR - ios example Aug 9, 2019
@mfdeveloper
Copy link
Owner

mfdeveloper commented Aug 20, 2019

Fix #16 #17 #11

@adelmojunnior I did some improvements in this PR:

  • Fix conflicts with branch [master]
  • Try add a .d.ts file to use this plugin with Typescript autocomplete [will be continued in another branch]

PS: I don't know why, but the declaration file with declare global { ... } works in VSCode but shows a compiler error in Angular/IONIC cli 😢 I trying create a @types/cordova-plugin-nativeview, but this require accept a PR in repo: DefinitelyTyped/DefinitelyTyped. This process can be late! I will try create a separeted scoped repo just for this!

  • Android refactor improvements in showMarket() method

I've release the tag 1.0.11. You can add this plugin directly with these changes like this:

{
   "dependencies": {
        "cordova-plugin-nativeview": "git+https://github.com/mfdeveloper/cordova-plugin-nativeview.git#1.0.11",
    }
}

@mfdeveloper mfdeveloper merged commit e4686a3 into master Aug 20, 2019
@mfdeveloper mfdeveloper deleted the mr-ios-example branch October 23, 2020 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants