Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Phoenix.Presence #1

Closed
philipgiuliani opened this issue Apr 4, 2018 · 6 comments
Closed

Add Phoenix.Presence #1

philipgiuliani opened this issue Apr 4, 2018 · 6 comments

Comments

@philipgiuliani
Copy link
Contributor

It would be nice to have support of the Presence class which is present in the phoenix.js.

Sample Javascript implementation: https://github.com/phoenixframework/phoenix/blob/master/assets/js/phoenix.js#L1148
@mfeckie
Copy link
Owner

mfeckie commented Apr 4, 2018

I'd be more than happy to receive a pull request to add this, but it's not something I'm going to have time to work on any time soon I'm afraid.

@philipgiuliani
Copy link
Contributor Author

philipgiuliani commented Apr 4, 2018 •
edited
Loading

I'm currently planning a project which will use your libary and needs presence support. So maybe I can add the implementation!

@mfeckie
Copy link
Owner

mfeckie commented Apr 4, 2018

Sounds good I'm happy to help where I can.

@g33kidd
Copy link

g33kidd commented Sep 1, 2018

@philipgiuliani any updates on this? I've been looking into writing this myself.

@philipgiuliani
Copy link
Contributor Author

Hi, I didn't implement this yet. Go ahead!

@j12n j12n mentioned this issue Apr 20, 2019
Merged
@mfeckie
Copy link
Owner

mfeckie commented Apr 28, 2019

implemented in #13

@mfeckie mfeckie closed this as completed Apr 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@g33kidd @mfeckie @philipgiuliani