Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation presence functionality #13

Merged
merged 12 commits into from
Apr 28, 2019
Merged

Implementation presence functionality #13

merged 12 commits into from
Apr 28, 2019

Conversation

j12n
Copy link
Contributor

@j12n j12n commented Apr 20, 2019 •
edited
Loading

Issue #1

I've taken a crack at implementing the phoenix presence functionality. Both core logic and tests are a direct port of the javascript code. All tests are passing but I haven't tested it in a real flutter app yet.

~Justin

@mfeckie
Copy link
Owner

mfeckie commented Apr 24, 2019

Thanks Justin.

I've been a bit time poor so am just getting around to reviewing this.

I've also gotten Travis CI setup (rather than codeship).

Would be good to rebase your work and have it run the tests on CI

Also FYI, have updated testing so it can now just run via pub run test

mfeckie
mfeckie reviewed Apr 24, 2019
View reviewed changes
Copy link
Owner

@mfeckie mfeckie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really welcome addition. I've provided some suggestions to consider.

lib/src/phoenix_presence.dart Outdated Show resolved Hide resolved
lib/src/phoenix_presence.dart Outdated Show resolved Hide resolved
lib/src/phoenix_presence.dart Outdated Show resolved Hide resolved
lib/src/phoenix_presence.dart Outdated Show resolved Hide resolved
lib/src/phoenix_presence.dart Outdated Show resolved Hide resolved
lib/src/phoenix_presence.dart Outdated Show resolved Hide resolved
lib/src/phoenix_presence.dart Show resolved Hide resolved
test/phoenix_presence_test.dart Outdated Show resolved Hide resolved
test/phoenix_presence_test.dart Outdated Show resolved Hide resolved
test/phoenix_presence_test.dart Outdated Show resolved Hide resolved
@j12n
Copy link
Contributor Author

j12n commented Apr 25, 2019

Hey Martin, thanks for the great feedback. I took a quick pass and addressed.

@mfeckie
Copy link
Owner

mfeckie commented Apr 25, 2019

Great.

One last thing.

Can you add an entry to the Changelog? (Next release with your stuff will be 0.2.0).

It'll be the first Changelog entry, but would be nice to add some rigour around documentation :)

@j12n
Copy link
Contributor Author

j12n commented Apr 28, 2019

Done! I added placeholders for versions 0.1.2 and 0.1.3 but didn't add the details.

@mfeckie mfeckie merged commit 14c2730 into mfeckie:master Apr 28, 2019
@mfeckie
Copy link
Owner

mfeckie commented Apr 28, 2019

Awesome

@mfeckie
Copy link
Owner

mfeckie commented Apr 28, 2019

Ok, release published https://pub.dartlang.org/packages/phoenix_wings/versions/0.2.0

Thanks so much @j12n

@mfeckie mfeckie mentioned this pull request Apr 28, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfeckie mfeckie mfeckie left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@j12n @mfeckie