Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar buttons are losing their square aspect ratio on GNU+Linux but not Wondows? #390

Open
eliheuer opened this issue Jun 7, 2023 · 1 comment

Comments

@eliheuer
Copy link
Contributor

eliheuer commented Jun 7, 2023

See this recent screenshot from Fredrick's computer, note that the toolbar icons have lost their square aspect ratio and are struggling to maintain vertical alignment in the center of the button.

image-mfek-toolbar-001

See this screenshot from my PC showing the same thing, I'm using Arch Linux with Wayland & Sway.

image-mfek-toolbar-002

Now note that on Matt's Windows PC the buttons retain the square aspect ration.

image-mfek-toolbar-003

If I multiply FONT_SCALE_FACTOR by 2 on line 50 & 51 of ../src/user_interface/gui/icons/button.rs I get square buttons again. I ideally there would be a way to lock the aspect ratio and it would be easier to center and align the toolbar buttons. Runebender does a really nice job of this and is worth looking at for reference.

image-mfek-toolbar-004

@eliheuer
Copy link
Contributor Author

eliheuer commented Jun 7, 2023

I'm working on a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant