Okina memory manager segfault fix #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artv3
commented
Jan 25, 2019
artv3
commented
Jan 25, 2019
camierjs
approved these changes
Jan 25, 2019
|
This looks good 👍 |
jdahm
approved these changes
Jan 25, 2019
jonwong12
pushed a commit
that referenced
this pull request
May 13, 2019
Okina memory manager segfault fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue #730 . By default, config.hpp sets
int ngpu = -1;but we have the following method
static inline bool gpuDisabled() { return Get().ngpu == 0; } which will return false if ngpu doesn't get overwritten to 0. A possible fix is to change the gpuDisabled criteria to
static inline bool gpuDisabled() { return Get().ngpu < 0; }