Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement more general initial guess mechanism #44

Merged
merged 7 commits into from
Mar 15, 2023
Merged

Conversation

pbrehmer
Copy link
Collaborator

Enable implementation of an initial guess function in Greedy. It dispatches on the info tuple and on the arguments that were passed to the assemble call. This is important e.g. when using quantum number conserving DMRG, where specific initial states (states with defined QNs) are necessary. On this occasion, the info tuple will also be improved.

@pbrehmer
Copy link
Collaborator Author

@mfherbst This should be relatively ready to merge (from my side). Any thoughts so far?

@pbrehmer pbrehmer requested a review from mfherbst March 13, 2023 14:02
src/greedy.jl Outdated Show resolved Hide resolved
src/greedy.jl Show resolved Hide resolved
src/greedy.jl Show resolved Hide resolved
src/lobpcg.jl Outdated Show resolved Hide resolved
@pbrehmer
Copy link
Collaborator Author

pbrehmer commented Mar 14, 2023

I now removed the Function type annotation and fixed the indentation. I also happened to find an edge case in the HamiltonianCache constructor when I was experimenting today, which is now correctly handled.

@mfherbst mfherbst merged commit 2010a10 into master Mar 15, 2023
@mfherbst mfherbst deleted the initial-guess branch March 15, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more quantities to info during greedy assembly More general initial guess mechanism
2 participants